Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect read/write kernels to DaphneIR and DaphneDSL #58

Open
daphne-eu opened this issue Jun 11, 2021 · 1 comment
Open

Connect read/write kernels to DaphneIR and DaphneDSL #58

daphne-eu opened this issue Jun 11, 2021 · 1 comment
Labels
P1 Needed for pipeline P1 (query + LM) of the CIDR paper.

Comments

@daphne-eu
Copy link
Owner

In GitLab by @pdamme on Jun 11, 2021, 17:33

The current readCsv-kernel requires a File object as an argument. This type does not exist (yet?) in DaphneIR, which makes an integration harder. Options include

  • Adding open/close operations to DaphneIR (and corresponding built-in functions to DaphneDSL), such that one can get a File-object via DaphneDSL.
  • Adding a kind of dispatcher kernel for the read/write-operations that already exist in DaphneIR. That kernel could do the open/close calls in C++ and forward the processing to the existing readCsv-kernel and writeCsv-kernel (issue Kernel for writeCsv-operation for DenseMatrix #57). One challenge would be how to marry this to the idea of asynchronous IO already partly implemented with the readCsv-kernel.

In any case, before someone starts implementing this, we should discuss it thoroughly, since it is an important design decision.

@daphne-eu
Copy link
Owner Author

In GitLab by @pdamme on Aug 6, 2021, 18:46

mentioned in commit 1408b41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Needed for pipeline P1 (query + LM) of the CIDR paper.
Projects
None yet
Development

No branches or pull requests

1 participant