Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: also restart sidecar-injector #4544

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

jfreeland
Copy link
Contributor

@jfreeland jfreeland commented Feb 17, 2025

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

I had to rotate my certificates using kubectl because:

⌛  Starting certificate rotation
ℹ️  generating fresh certificates
ℹ️  Updating certifcates in your Kubernetes cluster
ℹ️  Dapr control plane version 1.13.0-mariner detected in namespace dapr-system
❌  certificate rotation failed: chart "dapr" version "1.13.0-mariner" not found in https://dapr.github.io/helm-charts repository

And I followed the documentation but missed dapr-sidecar-injector. Before I restarted my sidecar injector deployment, I restarted my application and noticed that the sidecar injector did not insert sidecars, so my application broke.

Issue reference

@jfreeland jfreeland requested review from a team as code owners February 17, 2025 15:50
@jfreeland jfreeland force-pushed the chore/sidecar-injector branch 2 times, most recently from fc58ef9 to 8e0d5de Compare February 17, 2025 15:52
Signed-off-by: Joey Freeland <joey@free.land>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Should also add the scheduler server to this list.

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Joey Freeland <30938344+jfreeland@users.noreply.github.com>
Updating the dapr init -k command

Signed-off-by: Mark Fussell <markfussell@gmail.com>
@hhunter-ms hhunter-ms merged commit 2050a85 into dapr:v1.14 Feb 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants