Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor source generator generates invalid code for generic interfaces #1416

Closed
WhitWaldo opened this issue Dec 3, 2024 · 1 comment
Closed
Assignees
Labels
area/actor/client kind/bug Something isn't working

Comments

@WhitWaldo
Copy link
Contributor

Actor source generator (dotnet): Dapr.Actors.Generators.ActorClientGenerator
1.14.x

Expected Behavior

Given the following actor interface:

[GenerateActorClient]
    public interface IGenericActor<in TFoo> : IActor
    {
        [ActorMethod]
        Task DoSomethingAsync(TFoo foo);
    }

should emit a class like:

    public sealed class GenericActorClient<TFoo> : ActorServiceTest.IGenericActor<TFoo>
    {
        // ... body
    }

Actual Behavior

The source generator emits:

public sealed class GenericActorClient : ActorServiceTest.IGenericActor<TFoo>
    {
        // ... the body is okay
    }

which is invalid.

Steps to Reproduce the Problem

Code above is enough to repro. Example the output of the generator.

Release Note

RELEASE NOTE: FIX Bug in actor source generator

@m3nax
Copy link
Contributor

m3nax commented Dec 4, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/actor/client kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants