Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit 3db86bc

Browse files
authored
Require Dart 3.3 and the latest pkg:web (#326)
1 parent 1c4a923 commit 3db86bc

File tree

6 files changed

+16
-30
lines changed

6 files changed

+16
-30
lines changed

.github/workflows/test-package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
fail-fast: false
4343
matrix:
4444
os: [ubuntu-latest]
45-
sdk: [3.2, dev]
45+
sdk: [3.3, dev]
4646
steps:
4747
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
4848
- uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 2.4.4
2+
3+
* Require Dart `^3.3`
4+
* Require `package:web` `^0.5.0`.
5+
16
## 2.4.3
27

38
- `HtmlWebSocketChannel`: Relax the type of the websocket parameter to the

lib/html.dart

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,10 @@ import 'dart:typed_data';
88

99
import 'package:async/async.dart';
1010
import 'package:stream_channel/stream_channel.dart';
11-
import 'package:web/helpers.dart';
11+
import 'package:web/web.dart';
1212

1313
import 'src/channel.dart';
1414
import 'src/exception.dart';
15-
import 'src/web_helpers.dart';
1615

1716
/// A [WebSocketChannel] that communicates using a `dart:html` [WebSocket].
1817
class HtmlWebSocketChannel extends StreamChannelMixin
@@ -100,15 +99,15 @@ class HtmlWebSocketChannel extends StreamChannelMixin
10099
}
101100
// The socket API guarantees that only a single open event will be
102101
// emitted.
103-
innerWebSocket.onOpenX.first.then((_) {
102+
innerWebSocket.onOpen.first.then((_) {
104103
_readyCompleter.complete();
105104
_listen();
106105
});
107106
}
108107

109108
// The socket API guarantees that only a single error event will be emitted,
110109
// and that once it is no open or message events will be emitted.
111-
innerWebSocket.onErrorX.first.then((_) {
110+
innerWebSocket.onError.first.then((_) {
112111
// Unfortunately, the underlying WebSocket API doesn't expose any
113112
// specific information about the error itself.
114113
final error = WebSocketChannelException('WebSocket connection failed.');
@@ -119,11 +118,11 @@ class HtmlWebSocketChannel extends StreamChannelMixin
119118
_controller.local.sink.close();
120119
});
121120

122-
innerWebSocket.onMessageX.listen(_innerListen);
121+
innerWebSocket.onMessage.listen(_innerListen);
123122

124123
// The socket API guarantees that only a single error event will be emitted,
125124
// and that once it is no other events will be emitted.
126-
innerWebSocket.onCloseX.first.then((event) {
125+
innerWebSocket.onClose.first.then((event) {
127126
_closeCode = event.code;
128127
_closeReason = event.reason;
129128
_controller.local.sink.close();

lib/src/web_helpers.dart

Lines changed: 0 additions & 17 deletions
This file was deleted.

pubspec.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
name: web_socket_channel
2-
version: 2.4.3
2+
version: 2.4.4
33
description: >-
44
StreamChannel wrappers for WebSockets. Provides a cross-platform
55
WebSocketChannel API, a cross-platform implementation of that API that
66
communicates over an underlying StreamChannel.
77
repository: https://github.com/dart-lang/web_socket_channel
88

99
environment:
10-
sdk: ^3.2.0
10+
sdk: ^3.3.0
1111

1212
dependencies:
1313
async: ^2.5.0
1414
crypto: ^3.0.0
1515
stream_channel: ^2.1.0
16-
web: ^0.4.0
16+
web: ^0.5.0
1717

1818
dev_dependencies:
1919
dart_flutter_team_lints: ^2.0.0

test/html_test.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ import 'dart:typed_data';
1212
import 'package:async/async.dart';
1313
import 'package:stream_channel/stream_channel.dart';
1414
import 'package:test/test.dart';
15-
import 'package:web/helpers.dart' hide BinaryType;
15+
import 'package:web/web.dart' hide BinaryType;
1616
import 'package:web_socket_channel/html.dart';
17-
import 'package:web_socket_channel/src/web_helpers.dart';
1817
import 'package:web_socket_channel/web_socket_channel.dart';
1918

2019
extension on StreamChannel {
@@ -70,7 +69,7 @@ void main() {
7069

7170
test('communicates using an existing open WebSocket', () async {
7271
final webSocket = WebSocket('ws://localhost:$port');
73-
await webSocket.onOpenX.first;
72+
await webSocket.onOpen.first;
7473

7574
final channel = HtmlWebSocketChannel(webSocket);
7675

0 commit comments

Comments
 (0)