Skip to content

bizarre parameter wrapping when followed by block comment #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srawlins opened this issue Jun 13, 2023 · 2 comments
Closed

bizarre parameter wrapping when followed by block comment #1232

srawlins opened this issue Jun 13, 2023 · 2 comments

Comments

@srawlins
Copy link
Member

I don't generally check in code like this, but was commenting out a method's implementation and writing in a new one, and got some weird formatting. Here's a simple repro that works on DartPad:

int foo(List<int> list) /*
1234567     14     21     28     35     42     49
  */
    => 7;

formats to:

int foo(
        List<int>
            list) /*
1234567     14     21     28     35     42     49
  */
    =>
    7;

I think the =>\n7 is covered in other bugs... but the newline before List<int> and the newline before list each seem weird. Or at least one of them is. Note that if you remove even one character from the comment text, both of those newlines disappear.

@munificent
Copy link
Member

Yeah, that's pretty wonky.

@munificent
Copy link
Member

I have no idea what the old formatter is thinking, but the forthcoming tall style formatter produces:

int foo(List<int> list) /*
1234567     14     21     28     35     42     49
  */ => 7;

That looks OK to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants