Switch to specific ignores

.github/workflows/health.yaml

@@ -82,8 +82,16 @@ on:
         default: false
         required: false
         type: boolean
-      ignore:
-        description: Which files to ignore when checking for licenses.
+      ignore_license:
+        description: Which files to ignore for the license check.
+        required: false
+        type: string
+      ignore_coverage:
+        description: Which files to ignore for the coverage check.
+        required: false
+        type: string
+      ignore_packages:
+        description: Which packages to ignore.
         required: false
         type: string
 
@@ -98,7 +106,7 @@ jobs:
       warn_on: ${{ inputs.warn_on }}
       local_debug: ${{ inputs.local_debug }}
       use-flutter: ${{ inputs.use-flutter }}
-      ignore: ${{ inputs.ignore }}
+      ignore_packages: ${{ inputs.ignore_packages }}
 
   changelog:
     if: ${{ contains(inputs.checks, 'changelog') }}
@@ -110,7 +118,7 @@ jobs:
       warn_on: ${{ inputs.warn_on }}
       local_debug: ${{ inputs.local_debug }}
       use-flutter: ${{ inputs.use-flutter }}
-      ignore: ${{ inputs.ignore }}
+      ignore_packages: ${{ inputs.ignore_packages }}
 
   license:
     if: ${{ contains(inputs.checks, 'license') }}
@@ -122,7 +130,8 @@ jobs:
       warn_on: ${{ inputs.warn_on }}
       local_debug: ${{ inputs.local_debug }}
       use-flutter: ${{ inputs.use-flutter }}
-      ignore: ${{ inputs.ignore }}
+      ignore_license: ${{ inputs.ignore_license }}
+      ignore_packages: ${{ inputs.ignore_packages }}
 
   coverage:
     if: ${{ contains(inputs.checks, 'coverage') }}
@@ -136,7 +145,8 @@ jobs:
       coverage_web: ${{ inputs.coverage_web }}
       local_debug: ${{ inputs.local_debug }}
       use-flutter: ${{ inputs.use-flutter }}
-      ignore: ${{ inputs.ignore }}
+      ignore_coverage: ${{ inputs.ignore_coverage }}
+      ignore_packages: ${{ inputs.ignore_packages }}
 
   breaking:
     if: ${{ contains(inputs.checks, 'breaking') }}
@@ -148,7 +158,7 @@ jobs:
       warn_on: ${{ inputs.warn_on }}
       local_debug: ${{ inputs.local_debug }}
       use-flutter: ${{ inputs.use-flutter }}
-      ignore: ${{ inputs.ignore }}
+      ignore_packages: ${{ inputs.ignore_packages }}
 
   do-not-submit:
     if: ${{ contains(inputs.checks, 'do-not-submit') }}
@@ -160,7 +170,7 @@ jobs:
       warn_on: ${{ inputs.warn_on }}
       local_debug: ${{ inputs.local_debug }}
       use-flutter: ${{ inputs.use-flutter }}
-      ignore: ${{ inputs.ignore }}
+      ignore_packages: ${{ inputs.ignore_packages }}
 
   comment:
     needs: [version, changelog, license, coverage, breaking, do-not-submit]

.github/workflows/health_base.yaml

@@ -49,9 +49,16 @@ on:
         default: false
         required: false
         type: boolean
-      ignore:
-        description: The files to ignore for this check.
-        default: "[!*]"
+      ignore_license:
+        description: Which files to ignore for the license check.
+        required: false
+        type: string
+      ignore_coverage:
+        description: Which files to ignore for the coverage check.
+        required: false
+        type: string
+      ignore_packages:
+        description: Which packages to ignore.
         required: false
         type: string
 
@@ -117,7 +124,9 @@ jobs:
             ${{ fromJSON('{"true":"--coverage_web","false":""}')[inputs.coverage_web] }} \
             --fail_on ${{ inputs.fail_on }} \
             --warn_on ${{ inputs.warn_on }} \
-            --ignore ${{ inputs.ignore }}
+            --ignore_license ${{ inputs.ignore_license }} \
+            --ignore_coverage ${{ inputs.ignore_coverage }} \
+            --ignore_packages ${{ inputs.ignore_packages }}
 
       - run: test -f current_repo/output/comment.md || echo $'The ${{ inputs.check }} workflow has encountered an exception and did not complete.' >> current_repo/output/comment.md
         if: ${{ '$action_state' == 1 }}

.github/workflows/health_internal.yaml

@@ -15,4 +15,4 @@ jobs:
       checks: version,changelog,license,coverage,breaking,do-not-submit
       fail_on: version,changelog,do-not-submit
       warn_on: license,coverage,breaking
-      ignore_license: '**.g.dart'
+      ignore: '**.g.dart'

pkgs/firehose/bin/health.dart

@@ -15,8 +15,16 @@ void main(List<String> arguments) async {
       help: 'Check PR health.',
     )
     ..addMultiOption(
-      'ignore',
-      help: 'File which should be ignored by the health workflow.',
+      'ignore_packages',
+      help: 'Which packages to ignore.',
+    )
+    ..addMultiOption(
+      'ignore_license',
+      help: 'Which files to ignore for the license check.',
+    )
+    ..addMultiOption(
+      'ignore_coverage',
+      help: 'Which files to ignore for the coverage check.',
     )
     ..addMultiOption(
       'warn_on',
@@ -36,12 +44,22 @@ void main(List<String> arguments) async {
   var check = parsedArgs['check'] as String;
   var warnOn = parsedArgs['warn_on'] as List<String>;
   var failOn = parsedArgs['fail_on'] as List<String>;
-  var ignore = parsedArgs['ignore'] as List<String>;
+  var ignorePackages = parsedArgs['ignore_packages'] as List<String>;
+  var ignoreLicense = parsedArgs['ignore_license'] as List<String>;
+  var ignoreCoverage = parsedArgs['ignore_coverage'] as List<String>;
   var coverageWeb = parsedArgs['coverage_web'] as bool;
   if (warnOn.toSet().intersection(failOn.toSet()).isNotEmpty) {
     throw ArgumentError('The checks for which warnings are displayed and the '
         'checks which lead to failure must be disjoint.');
   }
-  await Health(Directory.current, check, warnOn, failOn, coverageWeb, ignore)
-      .healthCheck();
+  await Health(
+    Directory.current,
+    check,
+    warnOn,
+    failOn,
+    coverageWeb,
+    ignorePackages,
+    ignoreLicense,
+    ignoreCoverage,
+  ).healthCheck();
 }

pkgs/firehose/lib/firehose.dart

@@ -94,10 +94,10 @@ Saving existing comment id $existingCommentId to file ${idFile.path}''');
 
   Future<VerificationResults> verify(
     GithubApi github, [
-    List<Glob> ignoredFiles = const [],
+    List<Glob> ignoredPackages = const [],
   ]) async {
     var repo = Repository();
-    var packages = repo.locatePackages(ignoredFiles);
+    var packages = repo.locatePackages(ignoredPackages);
 
     var pub = Pub();
 

pkgs/firehose/lib/src/health/changelog.dart

@@ -12,11 +12,11 @@ import '../repo.dart';
 import '../utils.dart';
 
 Future<Map<Package, List<GitFile>>> packagesWithoutChangelog(
-    GithubApi github, List<Glob> ignoredFiles) async {
+    GithubApi github, List<Glob> ignoredPackages) async {
   final repo = Repository();
-  final packages = repo.locatePackages(ignoredFiles);
+  final packages = repo.locatePackages(ignoredPackages);
 
-  final files = await github.listFilesForPR(ignoredFiles);
+  final files = await github.listFilesForPR();
 
   var packagesWithoutChangedChangelog =
       collectPackagesWithoutChangelogChanges(packages, files);

pkgs/firehose/lib/src/health/coverage.dart

@@ -17,7 +17,9 @@ class Coverage {
   final bool coverageWeb;
   final List<Glob> ignoredFiles;
 
-  Coverage(this.coverageWeb, this.ignoredFiles);
+  final List<Glob> ignoredPackages;
+
+  Coverage(this.coverageWeb, this.ignoredFiles, this.ignoredPackages);
 
   Future<CoverageResult> compareCoverages(GithubApi github) async {
     var files = await github.listFilesForPR(ignoredFiles);
@@ -28,7 +30,7 @@ class Coverage {
 
   CoverageResult compareCoveragesFor(List<GitFile> files, String basePath) {
     var repository = Repository();
-    var packages = repository.locatePackages(ignoredFiles);
+    var packages = repository.locatePackages(ignoredPackages);
     print('Found packages $packages at ${Directory.current}');
 
     var filesOfInterest = files

pkgs/firehose/lib/src/health/health.dart

@@ -51,15 +51,21 @@ class Health {
     this.warnOn,
     this.failOn,
     this.coverageweb,
-    List<String> ignored,
-  ) : ignoredFiles = ignored.map(Glob.new).toList();
+    List<String> ignoredPackages,
+    List<String> ignoredLicense,
+    List<String> ignoredCoverage,
+  )   : ignoredPackages = ignoredPackages.map(Glob.new).toList(),
+        ignoredFilesForCoverage = ignoredCoverage.map(Glob.new).toList(),
+        ignoredFilesForLicense = ignoredLicense.map(Glob.new).toList();
   final github = GithubApi();
 
   final String check;
   final List<String> warnOn;
   final List<String> failOn;
   final bool coverageweb;
-  final List<Glob> ignoredFiles;
+  final List<Glob> ignoredPackages;
+  final List<Glob> ignoredFilesForLicense;
+  final List<Glob> ignoredFilesForCoverage;
 
   Future<void> healthCheck() async {
     // Do basic validation of our expected env var.
@@ -110,7 +116,8 @@ class Health {
 
   Future<HealthCheckResult> validateCheck() async {
     //TODO: Add Flutter support for PR health checks
-    var results = await Firehose(directory, false).verify(github, ignoredFiles);
+    var results =
+        await Firehose(directory, false).verify(github, ignoredPackages);
 
     var markdownTable = '''
 | Package | Version | Status |
@@ -128,7 +135,7 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati
   }
 
   Future<HealthCheckResult> breakingCheck() async {
-    final filesInPR = await github.listFilesForPR(ignoredFiles);
+    final filesInPR = await github.listFilesForPR();
     final changeForPackage = <Package, BreakingChange>{};
     final baseDirectory = Directory('../base_repo');
     for (var package in packagesContaining(filesInPR)) {
@@ -201,9 +208,11 @@ ${changeForPackage.entries.map((e) => '|${e.key.name}|${e.value.toMarkdownRow()}
   }
 
   Future<HealthCheckResult> licenseCheck() async {
-    var files = await github.listFilesForPR(ignoredFiles);
-    var allFilePaths =
-        await getFilesWithoutLicenses(Directory.current, ignoredFiles);
+    var files = await github.listFilesForPR(ignoredFilesForLicense);
+    var allFilePaths = await getFilesWithoutLicenses(
+      Directory.current,
+      ignoredFilesForLicense,
+    );
 
     var groupedPaths = allFilePaths
         .groupListsBy((path) => files.any((f) => f.relativePath == path));
@@ -245,7 +254,7 @@ ${unchangedFilesPaths.isNotEmpty ? unchangedMarkdown : ''}
   }
 
   Future<HealthCheckResult> changelogCheck() async {
-    var filePaths = await packagesWithoutChangelog(github, ignoredFiles);
+    var filePaths = await packagesWithoutChangelog(github, ignoredPackages);
 
     final markdownResult = '''
 | Package | Changed Files |
@@ -264,7 +273,7 @@ Changes to files need to be [accounted for](https://github.com/dart-lang/ecosyst
 
   Future<HealthCheckResult> doNotSubmitCheck() async {
     final body = await github.pullrequestBody();
-    final files = await github.listFilesForPR(ignoredFiles);
+    final files = await github.listFilesForPR();
     print('Checking for DO_NOT${'_'}SUBMIT strings: $files');
     final filesWithDNS = files
         .where((file) =>
@@ -294,8 +303,11 @@ ${filesWithDNS.map((e) => e.filename).map((e) => '|$e|').join('\n')}
   }
 
   Future<HealthCheckResult> coverageCheck() async {
-    var coverage =
-        await Coverage(coverageweb, ignoredFiles).compareCoverages(github);
+    var coverage = await Coverage(
+      coverageweb,
+      ignoredFilesForCoverage,
+      ignoredPackages,
+    ).compareCoverages(github);
 
     var markdownResult = '''
 | File | Coverage |
@@ -352,7 +364,7 @@ ${isWorseThanInfo ? 'This check can be disabled by tagging the PR with `skip-${r
   List<Package> packagesContaining(List<GitFile> filesInPR) {
     var files = filesInPR.where((element) => element.status.isRelevant);
     final repo = Repository();
-    return repo.locatePackages(ignoredFiles).where((package) {
+    return repo.locatePackages(ignoredPackages).where((package) {
       var relativePackageDirectory =
           path.relative(package.directory.path, from: Directory.current.path);
       return files.any(

pkgs/firehose/test/coverage_test.dart

@@ -43,7 +43,7 @@ void main() {
 }
 
 class FakeHealth extends Coverage {
-  FakeHealth() : super(true, []);
+  FakeHealth() : super(true, [], []);
 
   @override
   Map<String, double> getCoverage(Package? package) {