Don't report InconsistentAnalysisException for package:build

Bug: dart-lang/source_gen#721
Change-Id: If9ecb9d9c39a314187121c0622e5663bbc261bd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386862
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Author: scheglov

pkg/analyzer/lib/src/clients/build_resolvers/build_resolvers.dart

@@ -67,6 +67,7 @@ AnalysisDriverForPackageBuild createAnalysisDriver({
     externalSummaries: dataStore,
     packages: packages,
     macroSupport: KernelMacroSupport(),
+    shouldReportInconsistentAnalysisException: false,
   );
 
   scheduler.start();

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -245,6 +245,9 @@ class AnalysisDriver {
   /// Whether resolved units should be indexed.
   final bool enableIndex;
 
+  /// Whether analysis sessions should report inconsistent analysis.
+  final bool shouldReportInconsistentAnalysisException;
+
   /// The context in which libraries should be analyzed.
   LibraryContext? _libraryContext;
 
@@ -286,6 +289,7 @@ class AnalysisDriver {
     UnlinkedUnitStore? unlinkedUnitStore,
     InfoDeclarationStore? infoDeclarationStore,
     this.enableIndex = false,
+    this.shouldReportInconsistentAnalysisException = true,
     SummaryDataStore? externalSummaries,
     DeclaredVariables? declaredVariables,
     bool retainDataForTesting = false,

pkg/analyzer/lib/src/dart/analysis/session.dart

@@ -50,6 +50,10 @@ class AnalysisSessionImpl implements AnalysisSession {
   /// Check to see that results from this session will be consistent, and throw
   /// an [InconsistentAnalysisException] if they might not be.
   void checkConsistency() {
+    if (!_driver.shouldReportInconsistentAnalysisException) {
+      return;
+    }
+
     if (_driver.hasPendingFileChanges || _driver.currentSession != this) {
       throw InconsistentAnalysisException();
     }

pkg/analyzer/test/src/clients/build_resolvers/build_resolvers_test.dart

@@ -2,9 +2,14 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/sdk/build_sdk_summary.dart';
+import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/clients/build_resolvers/build_resolvers.dart';
+import 'package:analyzer/src/context/packages.dart';
+import 'package:analyzer/src/source/package_map_resolver.dart';
 import 'package:analyzer/src/test_utilities/mock_sdk.dart';
+import 'package:analyzer/src/test_utilities/package_config_file_builder.dart';
 import 'package:analyzer/src/test_utilities/resource_provider_mixin.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -17,7 +22,72 @@ main() {
 
 @reflectiveTest
 class AnalysisDriverForPackageBuildTest with ResourceProviderMixin {
+  File get testFile => getFile('$testPackageLibPath/test.dart');
+
+  String get testPackageLibPath => '$testPackageRootPath/lib';
+
+  String get testPackageRootPath => '$workspaceRootPath/test';
+
+  String get workspaceRootPath => '/home';
+
+  void setUp() {
+    newPubspecYamlFile(testPackageRootPath, r'''
+name: test
+''');
+
+    newPackageConfigJsonFileFromBuilder(
+      testPackageRootPath,
+      PackageConfigFileBuilder()
+        ..add(
+          name: 'test',
+          rootPath: testPackageRootPath,
+        ),
+    );
+  }
+
+  test_currentSession_afterChangeFile() async {
+    var analysisDriver = await _createAnalysisDriver();
+    var analysisSession = analysisDriver.currentSession;
+
+    var a = newFile('$testPackageLibPath/a.dart', r'''
+class A {}
+''');
+
+    analysisDriver.changeFile(a.path);
+
+    var unitResult = await analysisSession.getResolvedUnit(a.path);
+    unitResult as ResolvedUnitResult;
+  }
+
+  test_currentSession_getResolvedUnit() async {
+    var analysisDriver = await _createAnalysisDriver();
+    var analysisSession = analysisDriver.currentSession;
+
+    var a = newFile('$testPackageLibPath/a.dart', r'''
+class A {}
+''');
+
+    var unitResult = await analysisSession.getResolvedUnit(a.path);
+    unitResult as ResolvedUnitResult;
+    expect(unitResult.unit.declarations, hasLength(1));
+  }
+
   test_sdkLibraryUris() async {
+    var analysisDriver = await _createAnalysisDriver();
+
+    expect(
+      analysisDriver.sdkLibraryUris,
+      containsAll([
+        Uri.parse('dart:core'),
+        Uri.parse('dart:async'),
+        Uri.parse('dart:io'),
+        Uri.parse('dart:_internal'),
+      ]),
+    );
+  }
+
+  /// Creates the driver for [testFile].
+  Future<AnalysisDriverForPackageBuild> _createAnalysisDriver() async {
     var sdkRoot = getFolder('/sdk');
 
     createMockSdk(
@@ -30,22 +100,24 @@ class AnalysisDriverForPackageBuildTest with ResourceProviderMixin {
       sdkPath: sdkRoot.path,
     );
 
+    var packages = findPackagesFrom(resourceProvider, testFile);
+    var uriResolver = _toPackageMapUriResolver(packages);
+
     var analysisDriver = createAnalysisDriver(
       resourceProvider: resourceProvider,
       sdkSummaryBytes: sdkSummaryBytes,
       analysisOptions: AnalysisOptionsImpl(),
-      uriResolvers: [],
-      packages: Packages({}),
+      packages: packages,
+      uriResolvers: [uriResolver],
     );
+    return analysisDriver;
+  }
 
-    expect(
-      analysisDriver.sdkLibraryUris,
-      containsAll([
-        Uri.parse('dart:core'),
-        Uri.parse('dart:async'),
-        Uri.parse('dart:io'),
-        Uri.parse('dart:_internal'),
-      ]),
-    );
+  PackageMapUriResolver _toPackageMapUriResolver(Packages packages) {
+    var map = <String, List<Folder>>{};
+    for (var package in packages.packages) {
+      map[package.name] = [package.libFolder];
+    }
+    return PackageMapUriResolver(resourceProvider, map);
   }
 }