From f08ff356557dc5a80fade67033cfa1e664f2f894 Mon Sep 17 00:00:00 2001 From: William Levack Payne <108789355+WillLP-code@users.noreply.github.com> Date: Mon, 11 Nov 2024 14:20:31 +0000 Subject: [PATCH] ammend 4180 rule desc --- cin_validator/__main__.py | 2 +- cin_validator/rules/cin2022_23/rule_8614.py | 2 +- cin_validator/rules/cin2024_25/rule_4180.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cin_validator/__main__.py b/cin_validator/__main__.py index b8886243..29624ba0 100644 --- a/cin_validator/__main__.py +++ b/cin_validator/__main__.py @@ -79,7 +79,7 @@ def run_all(filename: str, ruleset, select, output): # get rules based on specified year. module = importlib.import_module(f"cin_validator.rules.{ruleset}") ruleset_registry = getattr(module, "registry") - + validator = cin_validator.CinValidator( data_files, ruleset_registry, selected_rules=select ) diff --git a/cin_validator/rules/cin2022_23/rule_8614.py b/cin_validator/rules/cin2022_23/rule_8614.py index ccfd868d..3c396b7e 100644 --- a/cin_validator/rules/cin2022_23/rule_8614.py +++ b/cin_validator/rules/cin2022_23/rule_8614.py @@ -62,7 +62,7 @@ def test_validate(): { "LAchildID": "child2", "AssessmentAuthorisationDate": "26/05/2000", - "AssessmentFactors": ['6a', '6b'], + "AssessmentFactors": ["6a", "6b"], }, { "LAchildID": "child3", diff --git a/cin_validator/rules/cin2024_25/rule_4180.py b/cin_validator/rules/cin2024_25/rule_4180.py index 03b9b636..b090d128 100644 --- a/cin_validator/rules/cin2024_25/rule_4180.py +++ b/cin_validator/rules/cin2024_25/rule_4180.py @@ -24,7 +24,7 @@ # replace ChildIdentifiers with the value in the module column of the excel sheet corresponding to this rule . module=CINTable.ChildIdentifiers, # replace the message with the corresponding value for this rule, gotten from the excel sheet. - message="Sex is missing", + message="Sex must be provided and equal M, F, or U", # The column names tend to be the words within the < > signs in the github issue description. affected_fields=[Sex], ) @@ -74,4 +74,4 @@ def test_validate(): # replace '4180' with the rule code and put the appropriate message in its place too. assert result.definition.code == "4180" - assert result.definition.message == "Sex is missing" + assert result.definition.message == "Sex must be provided and equal M, F, or U"