Automated code format update #142
Conversation
clkhash/bloomfilter.py
Outdated
| keys, # type: Sequence[bytes] | ||
| k, # type: int | ||
| l, # type: int | ||
| encoding # type: str |
There was a problem hiding this comment.
In Mypy’s Python 2 examples, the type annotations are aligned like in the original.
There was a problem hiding this comment.
I had a quick look and it didn't appear to be configurable 👎
I'm not particularly keen to go through and manually edit... if you feel strongly about it do you want to make any changes (or look into other tools that might reformat more optimally)
| import hmac | ||
| import math | ||
| import struct | ||
| from enum import Enum | ||
| from functools import partial | ||
| from hashlib import md5, sha1 |
There was a problem hiding this comment.
Seems that it’s listing namespace imports (import foo) before from imports (from foo import bar). This behaviour doesn’t seem to be part of PEP8. Looks better though!
| # with json.decoder.JSONDecodeError, | ||
| # but that doesn't exist in Python 2. | ||
| # with json.decoder.JSONDecodeError, | ||
| # but that doesn't exist in Python 2. |
There was a problem hiding this comment.
Yeah, fair enough. This comment should be on its own line in the first place.
| @@ -217,14 +216,14 @@ def get_master_schema(version): | |||
|
|
|||
| try: | |||
| schema_bytes = pkgutil.get_data('clkhash', | |||
| 'master-schemas/{}'.format(file_name)) | |||
| 'master-schemas/{}'.format(file_name)) | |||
hardbyte
force-pushed
the
feature-code-format-update
branch
from
b8b5443 to
b2bbe8e
Compare
|
As this got left behind and we had another PR which addressed code formating I've force pushed. Would you mind taking another quick look @nbgl |
Does the manual component of #99.
I just selected all files and asked pycharm to clean em up