Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevate CredentialManager to toplevel module #229

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Conversation

mih
Copy link
Member

@mih mih commented Feb 7, 2023

datalad_next.utils.credman -> datalad_next.credman

Closes #228

This is the start of a more stringent and versatile implementation of the functionality exposed by CredentialManager

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 89.51% // Head: 91.28% // Increases project coverage by +1.77% 🎉

Coverage data is based on head (46209ac) compared to base (bc979ab).
Patch coverage: 97.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   89.51%   91.28%   +1.77%     
==========================================
  Files          72       74       +2     
  Lines        6839     6565     -274     
==========================================
- Hits         6122     5993     -129     
+ Misses        717      572     -145     
Impacted Files Coverage Δ
datalad_next/utils/credman.py 0.00% <0.00%> (-98.24%) ⬇️
datalad_next/credman/manager.py 98.23% <98.23%> (ø)
datalad_next/commands/credentials.py 99.00% <100.00%> (ø)
datalad_next/credman/__init__.py 100.00% <100.00%> (ø)
datalad_next/credman/tests/test_credman.py 100.00% <100.00%> (ø)
datalad_next/utils/__init__.py 82.53% <100.00%> (ø)
datalad_next/annexremotes/uncurl.py 95.04% <0.00%> (-4.14%) ⬇️
datalad_next/gitremotes/datalad_annex.py 88.98% <0.00%> (-0.28%) ⬇️
datalad_next/_version.py 100.00% <0.00%> (+54.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mih mih merged commit 407053c into datalad:main Feb 8, 2023
@mih mih deleted the bf-228 branch February 8, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elevate credential manager to a top-level module
1 participant