Improve legacy credential handling (and test it) #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, we can now communicate to users what credentials are legacy and behave different from others. Closes datalad#246
Importantly this is now tested (only 5 lines are missing in the entire code base; 99% coverage). The key improvment is that users no longer have to provide type hints for legacy credentials that are known via a "provider configuration.
|
Test failures are #245 (I will get to you!!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we can now communicate to users what credentials are legacy and behave different from others.
Retrieval and update handling are also improved. Importantly this is now tested (only 5 lines are missing in the entire code base; 99% coverage).
The key improvment is that users no longer have to provide type hints
for legacy credentials that are known via a "provider configuration.
Closes #246
Ping #224 (this is not a formal backend, but works towards it by better defining the behavior)