Impl/cherry picks #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/apache/kafka/blob/61530d68ce83467de6190a52da37b3c0af84f0ef/core/src/main/scala/kafka/server/KafkaApis.scala#L1203-L1210 When a topic is not found, Kafka only returns `INVALID_TOPIC_EXCEPTION` when the topic name is invalid. If the topic name is valid, `UNKNOWN_TOPIC_OR_PARTITION` will be returned. - Refactor `getPartitionedTopicMetadataAsync` to return the correct error code (and rename this method). For the case when any error happens at the broker side, return `UNKNOWN_TOPIC_OR_PARTITION`. - Do not print error logs when the topic is not found. Kafka also does not print the logs. The Kafka client will print the logs for `UNKNOWN_TOPIC_OR_PARTITION`. - Add `testTopicMetadataNotFound` to verify the changes. (cherry picked from commit 4c22dfa)
### Motivation When using pulsar format and has messages In batch, we should use single message metadata's event time as the record timestamp. ### Modifications Use single message metadata's event time as the record timestamp (cherry picked from commit 539af59)
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## 2.10_ds #90 +/- ##
==============================================
+ Coverage 0 54.46% +54.46%
- Complexity 0 118 +118
==============================================
Files 0 19 +19
Lines 0 940 +940
Branches 0 80 +80
==============================================
+ Hits 0 512 +512
- Misses 0 411 +411
- Partials 0 17 +17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.