fix bug in streaming tenant import (#444)

After importing a streaming tenant, some state values are still unknown.
Make sure that the region in the state is not overridden by an empty
plan value.

Also deprecate the use of cloud_provider and region for streaming
tenant.

Author: pgier

docs/resources/streaming_tenant.md

@@ -75,10 +75,10 @@ output "web_socket_url" {
 
 ### Optional
 
-- `cloud_provider` (String) Cloud provider, one of `aws`, `gcp`, or `azure`. Required if `cluster_name` is not set.
+- `cloud_provider` (String, Deprecated) Cloud provider, one of `aws`, `gcp`, or `azure`. Required if `cluster_name` is not set.
 - `cluster_name` (String) Pulsar cluster name. Required if `cloud_provider` and `region` are not specified.
 - `deletion_protection` (Boolean) Whether or not to allow Terraform to destroy this tenant. Unless this field is set to false in Terraform state, a `terraform destroy` or `terraform apply` command that deletes the instance will fail. Defaults to `true`.
-- `region` (String) Cloud provider region. Required if `cluster_name` is not set.
+- `region` (String, Deprecated) Cloud provider region. Required if `cluster_name` is not set.
 - `topic` (String, Deprecated) Streaming tenant topic. Please use the `astra_streaming_topic` resource instead.
 
 ### Read-Only

internal/provider/resource_streaming_tenant.go

@@ -80,17 +80,19 @@ func (r *StreamingTenantResource) Schema(_ context.Context, _ resource.SchemaReq
 				},
 			},
 			"cloud_provider": schema.StringAttribute{
-				Description: "Cloud provider, one of `aws`, `gcp`, or `azure`. Required if `cluster_name` is not set.",
-				Optional:    true,
-				Computed:    true,
+				DeprecationMessage: "'cluster_name' should be used instead of 'cloud_provider' and 'region'.",
+				Description:        "Cloud provider, one of `aws`, `gcp`, or `azure`. Required if `cluster_name` is not set.",
+				Optional:           true,
+				Computed:           true,
 				PlanModifiers: []planmodifier.String{
-					stringplanmodifier.RequiresReplace(),
+					stringplanmodifier.RequiresReplaceIfConfigured(),
 				},
 			},
 			"region": schema.StringAttribute{
-				Description: "Cloud provider region. Required if `cluster_name` is not set.",
-				Optional:    true,
-				Computed:    true,
+				DeprecationMessage: "'cluster_name' should be used instead of 'cloud_provider' and 'region'.",
+				Description:        "Cloud provider region. Required if `cluster_name` is not set.",
+				Optional:           true,
+				Computed:           true,
 				PlanModifiers: []planmodifier.String{
 					//removeDashesModifier{},
 					//suppressDashesDiffModifier{},
@@ -315,7 +317,9 @@ func (r *StreamingTenantResource) Update(ctx context.Context, req resource.Updat
 
 	state.DeletionProtection = plan.DeletionProtection
 	state.UserEmail = plan.UserEmail
-	state.Region = plan.Region
+	if !plan.Region.IsNull() && !plan.Region.IsUnknown() {
+		state.Region = plan.Region
+	}
 
 	// Save updated data into Terraform state
 	resp.Diagnostics.Append(resp.State.Set(ctx, state)...)