update version 0.2

add compatibility for NVDA older versions (2018.2 and later) need testing.

Author: davidacm

addon/globalPlugins/synthRingSettingsSelector.py

@@ -5,10 +5,13 @@
 # Released under GPL 2
 #globalPlugins/synthRingSettingsSelector.py
 
-import config, globalPluginHandler, globalVars, gui, synthDriverHandler, wx, addonHandler
+import buildVersion, config, globalPluginHandler, globalVars, gui, synthDriverHandler, wx, addonHandler
 
 addonHandler.initTranslation()
 
+SETTINGS_ID = 'id'
+SETTINGS_AVAILABLE  = 'availableInSettingsRing'
+
 confspec = {
 	"availableSettings": "string_list(default=list('language', 'voice', 'variant', 'rate', 'rateBoost', 'volume', 'pitch', 'inflection'))"
 }
@@ -27,10 +30,11 @@ def setSynth(name,isFallback=False):
 	return r
 
 def setAvailableSettings():
-	if synthDriverHandler._curSynth:
+	if synthDriverHandler._curSynth and globalVars.settingsRing:
 		for s in synthDriverHandler._curSynth.supportedSettings:
-			s.availableInSettingsRing = True if s.id in config.conf['synthRingSettingsSelector']['availableSettings'] else False
-		if globalVars.settingsRing: globalVars.settingsRing.updateSupportedSettings(synthDriverHandler._curSynth)
+			setattr(s, SETTINGS_AVAILABLE, True if getattr(s, SETTINGS_ID) in config.conf['synthRingSettingsSelector']['availableSettings'] else False)
+		globalVars.settingsRing.updateSupportedSettings(synthDriverHandler._curSynth)
+
 
 class SynthRingSettingsSelectorSettingsPanel(gui.SettingsPanel):
 	# Translators: This is the label for the Synth ring settings selector  settings category in NVDA Settings screen.
@@ -46,8 +50,8 @@ def makeSettings(self, settingsSizer):
 		sHelper.addItem(settingsGroup)
 		self.settingsCheckbox = {}
 		for k in synthDriverHandler._curSynth.supportedSettings:
-			self.settingsCheckbox[k.id] = settingsGroup.addItem(wx.CheckBox(self, label =k.displayNameWithAccelerator))
-			self.settingsCheckbox[k.id].SetValue(k.id in self.curSettings)
+			self.settingsCheckbox[getattr(k, SETTINGS_ID)] = settingsGroup.addItem(wx.CheckBox(self, label =k.displayNameWithAccelerator))
+			self.settingsCheckbox[getattr(k, SETTINGS_ID)].SetValue(getattr(k, SETTINGS_ID) in self.curSettings)
 
 	def onSave(self):
 		newSettings = []
@@ -59,9 +63,14 @@ def onSave(self):
 		config.post_configProfileSwitch.notify()
 
 
+
 class GlobalPlugin(globalPluginHandler.GlobalPlugin):
 	def __init__(self):
+		global SETTINGS_AVAILABLE, SETTINGS_ID
 		super(globalPluginHandler.GlobalPlugin, self).__init__()
+		if int(buildVersion.formatBuildVersionString()[:6].replace(".", "")) < 20192:
+			SETTINGS_ID = 'name'
+			SETTINGS_AVAILABLE = 'availableInSynthSettingsRing'
 		self.handleConfigProfileSwitch()
 		config.post_configProfileSwitch.register(self.handleConfigProfileSwitch)
 		synthDriverHandler.setSynth = setSynth
@@ -77,4 +86,4 @@ def terminate(self):
 		synthDriverHandler.setSynth = origSetSynth
 		gui.settingsDialogs.setSynth = origSetSynth
 		gui.settingsDialogs.NVDASettingsDialog.categoryClasses.remove(SynthRingSettingsSelectorSettingsPanel)
-		config.post_configProfileSwitch.unregister(self.handleConfigProfileSwitch)
+		config.post_configProfileSwitch.unregister(self.handleConfigProfileSwitch)

buildVars.py

@@ -19,15 +19,15 @@
 	# Translators: Long description to be shown for this add-on on add-on information from add-ons manager
 	"addon_description" : _("""This add-on allows the user to select which     settings should appear on the synth settings ring."""),
 	# version
-	"addon_version" : "0.2",
+	"addon_version" : "0.3",
 	# Author(s)
 	"addon_author" : u"David CM <dhf360@gmail.com>",
 	# URL for the add-on documentation support
 	"addon_url" : "https://github.com/david-acm/NVDA-synthRingSettingsSelector",
 	# Documentation file name
 	"addon_docFileName" : "readme.html",
 	# Minimum NVDA version supported (e.g. "2018.3.0")
-	"addon_minimumNVDAVersion" : "2019.2.0",
+	"addon_minimumNVDAVersion" : "2018.2.0",
 	# Last NVDA version supported/tested (e.g. "2018.4.0", ideally more recent than minimum version)
 	"addon_lastTestedNVDAVersion" : "2019.2.0",
 	# Add-on update channel (default is stable or None)