Update ShowTaskDirect to correctly handle --limit -1

[WilliamDee]

Problem

In dbt show, if we don't pass --limit it defaults to 5 and renders LIMIT 5 at the end of the SQL. You can get around it by adding --limit -1 so that it doesn't render the LIMIT. However, it seems like that only works for --inline and if you try doing dbt show --inline-direct <> --limit -1 it errors with an adapter error showing cannot limit by a negative row number for certain adapters. In the ShowRunner we handle this case by limit = None if self.config.args.limit < 0 else self.config.args.limit, but this isn't the case for ShowTaskDirect.

Solution

update ShowTaskDirect so that the limit gets set to None if it's a negative int when passed to the adapter.

Checklist

• I have read the contributing guide and understand what's expected of me.
• I have run this code in development, and it appears to resolve the stated issue.
• This PR includes tests, or tests are not required or relevant for this PR.
• This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
• This PR includes type annotations for new and modified functions.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (55e0df1) to head (0f51efe).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11284      +/-   ##
==========================================
- Coverage   88.96%   88.89%   -0.07%     
==========================================
  Files         189      189              
  Lines       24138    24139       +1     
==========================================
- Hits        21474    21458      -16     
- Misses       2664     2681      +17     

Flag	Coverage Δ
integration	86.15% <100.00%> (-0.15%)	⬇️
unit	62.56% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Unit Tests	62.56% <0.00%> (-0.01%)	⬇️
Integration Tests	86.15% <100.00%> (-0.15%)	⬇️

[aranke]

LGTM, thanks!