Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: populate actual count of failures in run_results.json for passing tests #9657

Closed
wants to merge 7 commits into from
Closed

Feat: populate actual count of failures in run_results.json for passing tests #9657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1517de9
Feat: populate failures even test are passed
tbog357 Feb 25, 2024
21d0000
Ref: add changelog entry file
tbog357 Mar 23, 2024
d509f51
Update changelog description
dbeatty10 Apr 3, 2024
b4e95da
Ref: update test cases for schema
tbog357 Sep 8, 2024
280a8f8
Merge branch 'main' into patch-2
tbog357 Sep 8, 2024
b68dd0e
Ref: modify total failures in tests schema
tbog357 Sep 8, 2024
a887292
Merge branch 'dbt-labs:main' into patch-2
tbog357 Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Features-20240323-172105.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Features
body: Populate actual count of failures in `run_results.json` for passing tests
time: 2024-03-23T17:21:05.10213675+07:00
custom:
Author: tbog357
Issue: "9808"
1 change: 1 addition & 0 deletions core/dbt/task/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ def build_test_run_result(self, test: TestNode, result: TestResultData) -> RunRe
failures = result.failures
else:
status = TestStatus.Pass
failures = result.failures

run_result = RunResult(
node=test,
Expand Down
18 changes: 9 additions & 9 deletions tests/functional/schema_tests/test_schema_v2_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def assertTestFailed(self, result):
def assertTestPassed(self, result):
assert result.status == "pass"
assert not result.skipped
assert result.failures == 0, "test {} failed".format(result.node.name)
assert result.failures >= 0, "test {} failed".format(result.node.name)

def test_schema_tests(
self,
Expand Down Expand Up @@ -213,7 +213,7 @@ def assertTestWarn(self, result):
def assertTestPassed(self, result):
assert result.status == "pass"
assert not result.skipped
assert result.failures == 0, "test {} failed".format(result.node.name)
assert result.failures >= 0, "test {} failed".format(result.node.name)

def test_limit_schema_tests(
self,
Expand All @@ -235,7 +235,7 @@ def test_limit_schema_tests(
else:
self.assertTestPassed(result)
# warnings are also marked as failures
assert sum(x.failures for x in test_results) == 3
assert sum(x.failures for x in test_results) == 4


class TestDefaultBoolType:
Expand Down Expand Up @@ -264,7 +264,7 @@ def assertTestWarn(self, result):
def assertTestPassed(self, result):
assert result.status == "pass"
assert not result.skipped
assert result.failures == 0, "test {} failed".format(result.node.name)
assert result.failures >= 0, "test {} failed".format(result.node.name)

def test_limit_schema_tests(
self,
Expand All @@ -286,7 +286,7 @@ def test_limit_schema_tests(
else:
self.assertTestPassed(result)
# warnings are also marked as failures
assert sum(x.failures for x in test_results) == 3
assert sum(x.failures for x in test_results) == 4


class TestOtherBoolType:
Expand Down Expand Up @@ -331,7 +331,7 @@ def assertTestWarn(self, result):
def assertTestPassed(self, result):
assert result.status == "pass"
assert not result.skipped
assert result.failures == 0, "test {} failed".format(result.node.name)
assert result.failures >= 0, "test {} failed".format(result.node.name)

def test_limit_schema_tests(
self,
Expand All @@ -353,7 +353,7 @@ def test_limit_schema_tests(
else:
self.assertTestPassed(result)
# warnings are also marked as failures
assert sum(x.failures for x in test_results) == 3
assert sum(x.failures for x in test_results) == 4


class TestNonBoolType:
Expand Down Expand Up @@ -478,7 +478,7 @@ def test_hooks_do_run_for_tests(
for result in results:
assert result.status == "pass"
assert not result.skipped
assert result.failures == 0, "test {} failed".format(result.node.name)
assert result.failures >= 0, "test {} failed".format(result.node.name)


class TestHooksForWhich:
Expand Down Expand Up @@ -511,7 +511,7 @@ def test_these_hooks_dont_run_for_tests(
for result in results:
assert result.status == "pass"
assert not result.skipped
assert result.failures == 0, "test {} failed".format(result.node.name)
assert result.failures >= 0, "test {} failed".format(result.node.name)


class TestCustomSchemaTests:
Expand Down