Skip to content

Commit 95f2211

Browse files
authored
Merge pull request #137 from cgunther/brpop-timeout
Fix deprecation of passing timeout as positional argument to brpop
2 parents 0a33979 + 3147c28 commit 95f2211

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Changelog
22

3+
- #137 - Fix deprecation of passing timeout as positional argument to brpop
4+
35
## [4.3.0] - 2022-08-16
46

57
- #135 - Some extra fixes for Sidekiq 6.5 (fixes #128, #130, #131) from [@BobbyMcWho](https://github.com/BobbyMcWho)

lib/sidekiq/limit_fetch.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def redis_brpop(queues)
7070
sleep TIMEOUT # there are no queues to handle, so lets sleep
7171
[] # and return nothing
7272
else
73-
redis_retryable { Sidekiq.redis { |it| it.brpop *queues, TIMEOUT } }
73+
redis_retryable { Sidekiq.redis { |it| it.brpop *queues, timeout: TIMEOUT } }
7474
end
7575
end
7676
end

0 commit comments

Comments
 (0)