move ts own process to use chokidar #1070
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are now using
sdk-commands
as child process of other apps (creator-hub, etc), creating child processes of child processes seems to be having problems maintaining them alive when needed.This avoids creating a new keepalive process when running
tsc
on the user's scene by usingchokidar
. The only gotcha is having to parse thetsconfig.json
file so we can obtain the proper files to watch, so that's what the newgetTypeScriptWatchPatterns
function is doing.Tested it inside and outside Electron app, having different configs inside the
tsconfig.json
file and seems to be doing a proper work.