Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 0020: DID Reference Changes #22

Closed
TelegramSam opened this issue May 27, 2019 · 11 comments
Closed

RFC 0020: DID Reference Changes #22

TelegramSam opened this issue May 27, 2019 · 11 comments
Labels
question Further information is requested

Comments

@TelegramSam
Copy link
Contributor

The DID spec is evolving, and the DID deference example used in RFC 20 isn't going to be accurate. Current example:
did:sov:123456789abcdefghi1234;spec/exampleprotocol/1.0/exampletype
Likely new syntax:
did:sov:123456789abcdefghi1234;service=spec/exampleprotocol/1.0/exampletype

When should we make this change? What considerations are needed for the transition?

@peacekeeper
Copy link
Member

+1 this ABNF change has been merged into the DID spec here: w3c-ccg/did-spec#189

@dhh1128
Copy link
Contributor

dhh1128 commented May 31, 2019

+1 to making the change
I say that we rev all Indy protocol versions 1.1 if they were at 1.0 as they move into Aries, and say that acceptance of them in Aries requires the new format at the same time they get the 1.1 version.

@dhh1128 dhh1128 changed the title concepts/0020-message-types DID Reference Changes 0020: DID Reference Changes May 31, 2019
@tplooker
Copy link
Member

tplooker commented Jun 1, 2019

I'd like us to make sure we follow semver conventions around versioning these message families, what would be the rational for bumping to 1.1 if the message type representation was also changing?

@dhh1128
Copy link
Contributor

dhh1128 commented Jun 1, 2019

Good point @tplooker; maybe that resets everything to 0.9 with new message family identifier until accepted by the Aries community, then to 1.0?

@tplooker
Copy link
Member

tplooker commented Jun 1, 2019

Yes I would like to be sub 1.0 until the community agrees as that allows minor version bumps to be breaking changes and stops us from eating through major versions until the protocols are stable

@tplooker
Copy link
Member

tplooker commented Jun 1, 2019

We can proposed the current indy origin message protocols as 0.1 or anything sub 1.0 and then iterate with new minor versions until we agree, then we can bump to 1.0

@dhh1128
Copy link
Contributor

dhh1128 commented Jun 2, 2019

@tplooker FWIW the semver compliance goal you articulated is also formally written up here: https://github.com/hyperledger/aries-rfcs/blob/master/concepts/0003-protocols/semver.md. So we should be following what we already said. Thanks for holding us to it. :-)

@llorllale
Copy link
Contributor

I assume this change will propagate to all message type definitions.

@dhh1128 dhh1128 changed the title 0020: DID Reference Changes RFC 0020: DID Reference Changes Jun 7, 2019
@TelegramSam
Copy link
Contributor Author

what timing should we effect for this? Should we do a blanket update of RFCs with the minor update? Should we wait?

@dhh1128
Copy link
Contributor

dhh1128 commented Jun 10, 2019

I suggest that we update all of the version numbers asap, as one PR.

@kdenhartog kdenhartog added the question Further information is requested label Jun 19, 2019
@TelegramSam
Copy link
Contributor Author

Closing this in favor of switching Types away from DIDs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants