Harden the regex for space admins query

[sdelcroix]

Fixes #383

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (ccb89b5) to head (1dcffff).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files         146      146           
  Lines        3735     3735           
=======================================
  Hits         3634     3634           
  Misses        101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[microstudi]

Would you mind to explain why this is necessary?

[sdelcroix]

@microstudi Hi :)

Aren’t the details provided in the issue sufficient? I’m not sure what more I can add / say more.

[microstudi]

I that issue you say that this addition to the regex solves the problem. However you also say that you just asked chatgpt, I don't have anything against it but it indicates that you don't know what this regex addition exactly does. I would like a clarification to ensure there are no more cases that can arise due this addition.

Also, this PR does not have a test to check that effectively it solves the bug., You thing you could add one?

[sdelcroix]

Thanks for the answer @microstudi
I understand, that's fair ;)

As you can see in the commit, the part (?!\\d) has been added to the regex to be sure that the "searched" id is strictly found, and not followed by any other number.
Thus, if "8" is "searched", the regex won't return users with id beginning by "8" (81, 809, 813, 8xxx, ...).
If "81" is "searched", the regex won't return users with id beginning by "81" (812, 8145 ,81xxx, ...).
And so on.

Unfortunately, I'm not a ruby / RoR developer. I only contribute, in the Decidim ecosystem, with very small fixes which involve general programming knowledge.
So I don't have any in writing tests / specs for Ruby / RoR applications.

I'm open to learn though ! :)