Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credit renewal flow #77

Merged
merged 168 commits into from
May 13, 2024
Merged

Credit renewal flow #77

merged 168 commits into from
May 13, 2024

Conversation

antopalidi
Copy link
Collaborator

@antopalidi antopalidi commented Feb 23, 2024 •
edited
Loading

fixes #76

the review requires the previous PR to be merged (#71)

Screenshot 2024-02-22 at 19 51 11

Screenshot 2024-02-22 at 19 51 16

@antopalidi
add census type radio buttons
a6f5f03
@antopalidi
fix lint
ec6ad16
@antopalidi
fix transformLocales
6fd71fa
@antopalidi
createion elections with cencus permissions
2bf8658
@antopalidi
add batch queue
cc24956
@antopalidi
add verification methods for voting
c80d217
@antopalidi
remove whenever, add info to readme
3c4fa6d
@antopalidi
update the vocdoni census after delete authorization
1e682d1
@antopalidi
add internal_census field
30ad6b9
@antopalidi
change readme
b9679de
@antopalidi
change views vote
d4ad2f9
@antopalidi
add helper method
ea90440
@antopalidi
add modal window, add internal census logic to voting
1000ce0
@antopalidi
add loginModal
976b419
@antopalidi
fix login modal, fix wallet generation
429df0f
@antopalidi
create election without verification_types
861c6c0
@antopalidi
create election without voters
ba92b70
@antopalidi
fix erb linter
0bc546e
@antopalidi
refactoring, add system tests for internsl census
f0594a3
@antopalidi
change titles in census form
56430b3
@antopalidi
fix preview, fix tests
7a9c326
@antopalidi
fix missink keys
a3d5ffb
@antopalidi
fix use doublequote quotes
d45f0d1
@antopalidi
add spec for job
6e0bbe3
@antopalidi
fic create internal command, add tests
ebbd5dd
@antopalidi
add spec for cell
d5659c0
@antopalidi
add spec for form
bac6ed3
@antopalidi
add spec for controller
9048e4b
@antopalidi
add spec for AuthorizationsData model
b854fe4
@antopalidi
add spec for AuthorizationExtensions
e710d27
@antopalidi antopalidi self-assigned this Feb 23, 2024
@antopalidi antopalidi mentioned this pull request Feb 27, 2024
Merged
@carolromero
Copy link

Hi team! After review and discussion, there are still some questions about how the whole flow of credit renewal will work. But there are a couple of changes that make sense to me:

  • Move the credit warning at the component level. There's already an information banner so we need to think that UI.
  • Show the available credits when creating the election, perhaps on the first tab.

I'll propose some mockups ASAP.

@antopalidi antopalidi linked an issue Mar 13, 2024 that may be closed by this pull request
Credit renewal flow #73
Closed
4 tasks
@carolromero
Copy link

Here are the mockups and the copys

Vocdoni-credits

image

microstudi
microstudi previously approved these changes May 13, 2024
View reviewed changes
@microstudi microstudi merged commit 7b49435 into main May 13, 2024
3 checks passed
@microstudi microstudi deleted the feature/credit-flow-update branch May 22, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microstudi microstudi microstudi left review comments

Assignees

@antopalidi antopalidi

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Credit renewal flow
3 participants
@antopalidi @carolromero @microstudi