Fix empty cart type (#991)

* Fix event type to be any object. Empty array is not a valid json schema type. * Lint
deco-cx · Jan 24, 2025 · 7d2725f · 7d2725f
1 parent d2515a9
commit 7d2725f
Show file tree

Hide file tree

Showing 5 changed files with 909 additions and 897 deletions.
diff --git a/verified-reviews/utils/client.ts b/verified-reviews/utils/client.ts
@@ -102,13 +102,21 @@ export const createClient = (params: ConfigVerifiedReviews | undefined) => {
   };
   /** @description https://documenter.getpostman.com/view/2336519/SVzw6MK5#daf51360-c79e-451a-b627-33bdd0ef66b8 */
   const reviews = (
-    { productId, count = 5, offset = 0, order: _order = "date_desc", customizeOrder = false }:
+    {
+      productId,
+      count = 5,
+      offset = 0,
+      order: _order = "date_desc",
+      customizeOrder = false,
+    }:
       & PaginationOptions
       & {
         productId: string | string[];
       },
   ) => {
-    const order = customizeOrder ? _order : orderMap[_order as keyof typeof orderMap];
+    const order = customizeOrder
+      ? _order
+      : orderMap[_order as keyof typeof orderMap];
 
     const payload = {
       query: "reviews",

diff --git a/vtex/actions/analytics/sendEvent.ts b/vtex/actions/analytics/sendEvent.ts
@@ -16,7 +16,9 @@ export type Props =
   }
   | {
     type: "page.empty_cart";
-    products: [];
+    // Empty array is converted to a invalid json schema... so, let it be anything.
+    // deno-lint-ignore ban-types
+    products: {};
   }
   | {
     type: "page.confirmation";

diff --git a/vtex/loaders/promotion/getPromotionById.ts b/vtex/loaders/promotion/getPromotionById.ts
@@ -9,7 +9,7 @@ interface Props {
   idCalculatorConfiguration: string;
 }
 
-export const defaultVisibility = 'private' 
+export const defaultVisibility = "private";
 
 export default async function loader(
   props: Props,