Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vary shopify loaders cacheKey based on filters querystrings from request URL #838

Closed
igorbrasileiro opened this issue Sep 4, 2024 · 3 comments · Fixed by #851
Closed
Labels

Comments

@igorbrasileiro
Copy link
Contributor

Issue Type

Please inform the type(s) of issue(s) you are reporting:

  • Bug Report

Description

The shopify loaders/productListingPage is not varying the cacheKey based on filters querystring that comes from URL.

Steps to Reproduce (for bugs)

  1. Go to https://htmx.store/men?sort=price-ascending&page=0
  2. Click on in stock filter
  3. Click on Out of stock filter

Expected Behavior

Change the product list to only have out-of-stock products

Actual Behavior

It is returning in-stock products.

Additional Context

The issue happen because the cache key returns the same value, not varying the cache burst (__cb)


Thank you for taking the time to report this issue!

@gr4yt3x
Copy link
Contributor

gr4yt3x commented Sep 6, 2024

I am unable to reproduce the bug in my local environment at
https://localhost--storefront.deco.site/men?sort=price-ascending&page=0.

Here is a video of my local service running: https://www.loom.com/share/b3308c8320024841890f467d2e07b9ad?sid=33522fa4-b897-4c3c-b159-1b5ba75a103b

Can you provide any help on how to reproduce it?

@igorbrasileiro
Copy link
Contributor Author

Can you try here: https://sites-storefront--issue-838.decocdn.com/men ?

@matheusgr
Copy link
Contributor

#851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants