Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shopify]: add productType to product transformation #1003

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

yuriassuncx
Copy link
Contributor

@yuriassuncx yuriassuncx commented Feb 11, 2025

What is this Contribution About?

Pull Request Description:

This Pull Request adds the productType value returned by Shopify to the product's additional properties. The change ensures that the productType, which was previously not being considered, is now correctly included. The implementation details are as follows:

  1. The productType value is extracted from the product object returned by Shopify.
  2. A new PropertyValue object is created with the name "productType", and its value is set to the productType value from the product.
  3. This new PropertyValue is concatenated with other additional properties, such as the product description and metafields, within the additionalProperty array.

Example:

image

Context:

In the current repository, there is some confusion with the type object returned by the Deco.cx CMS, which follows the schema.org Product standard. This structure differs from the value returned by Shopify's productType. To address this and ensure data integrity, we decided to include the productType value directly in the product's additional properties, making it easier to work with this data in the application.

image

This change is necessary for implementing a feature for Zeedog Italy. It will allow us to correctly handle and display the product type as required by the feature's specifications.

Copy link
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.64.27 update
  • 🎉 for Minor 0.65.0 update
  • 🚀 for Major 1.0.0 update

@matheusgr matheusgr merged commit 3b55032 into deco-cx:main Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants