Allow users to specify search params on route path #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
Tagging OptionsShould a new tag be published when this PR is merged?
|
Signed-off-by: Marcos Candeia <marrcooos@gmail.com>
|
Additional: https://github.com/deco-cx/deco/pull/826/files |
guitavano
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this Contribution About?
Allow users to specify search params on route path to be used by URLPattern.
URLPattern already support search params, we are not using it so far, but we have now included. Users needs to specify following URLPattern documentation.
Example usecase in the linked issue.
Issue Link
Please link to the relevant issue that this pull request addresses: