[WAKE] previous page button #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging OptionsShould a new tag be published when this PR is merged?
|
matheusgr
requested changes
Sep 24, 2024
Co-authored-by: Matheus Gaudencio do Rêgo <matheusgr@users.noreply.github.com>
|
@lucas-social thanks for the changes. Has the hasPreviousPage work as expected when pageOffset is zero?
|
|
hey Gaudêncio, I’m still doing some tests but without success. i think it would be interesting to have closer contact since this is affecting my project and could impact its delivery. what do you think? |
|
Seems to be working with the current code, but a bug was found in the process of writing the .deco json files. when the json value was 0, deco did not seem to write it. Probably a bug either on our admin or ir our daemon, in some check for a falsy value. Lucas could follow by now by editing the json directly. |
viktormarinho
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of PR #859
"previous page" button was replicating the same products on the tested page and did not change the parameter as it repeated the current page