Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add replace on shopify #921

Merged
merged 1 commit into from
Oct 16, 2024
Merged

add replace on shopify #921

merged 1 commit into from
Oct 16, 2024

Conversation

guitavano
Copy link
Contributor

@guitavano guitavano commented Oct 11, 2024 •
edited by matheusgr
Loading

What is this Contribution About?

Allow proxy on shopify to replace content.

Example:

  • some shopify JS may refer the internal domain (site.myshopify.com) that provides an graphql API. This API is accessible only thought a server due to missing CORS headers, so it need a proxy to access it. We can replace this domain with our server so it has a way to access it.

@github-actions GitHub Actions
Copy link
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.62.5 update
  • 🎉 for Minor 0.63.0 update
  • 🚀 for Major 1.0.0 update

@guitavano guitavano requested a review from matheusgr October 15, 2024 11:24
@guitavano guitavano merged commit abee205 into main Oct 16, 2024
2 of 3 checks passed
@guitavano guitavano deleted the tavano/shopify-replaces branch October 16, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusgr matheusgr matheusgr approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guitavano @matheusgr