Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pickupHolidays type #963

Merged
merged 4 commits into from
Dec 23, 2024
Merged

feat: add pickupHolidays type #963

merged 4 commits into from
Dec 23, 2024

Conversation

soutofernando
Copy link
Contributor

What is this Contribution About?

Please provide a brief description of the changes or enhancements you are proposing in this pull request.

Issue Link

Please link to the relevant issue that this pull request addresses:

Loom Video

Record a quick screencast describing your changes to help the team understand and review your contribution. This will greatly assist in the review process.

Demonstration Link

Provide a link to a branch or environment where this pull request can be tested and seen in action.

@github-actions GitHub Actions
Copy link
Contributor

Tagging Options

Should a new tag be published when this PR is merged?

  • 👍 for Patch 0.64.3 update
  • 🎉 for Minor 0.65.0 update
  • 🚀 for Major 1.0.0 update

vitoUwu
vitoUwu requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@vitoUwu vitoUwu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I added some comments about using specialOpeningHoursSpecification property as it's supported by schema.org and meets your needs. Fixing that, everything looks fine to merge.

@vitoUwu vitoUwu added the vtex VTEX App label Dec 5, 2024
vitoUwu
vitoUwu reviewed Dec 18, 2024
View reviewed changes
@soutofernando soutofernando merged commit b03f5ca into main Dec 23, 2024
1 check passed
@soutofernando soutofernando deleted the feat-pickUpHolidays branch December 23, 2024 21:37
vitoUwu pushed a commit that referenced this pull request Jan 30, 2025
@soutofernando @vitoUwu
feat: add pickupHolidays type (#963)
a6f91da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitoUwu vitoUwu vitoUwu approved these changes

@guitavano guitavano Awaiting requested review from guitavano

Assignees
No one assigned
Labels
vtex VTEX App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soutofernando @vitoUwu