-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: incorrect fee displayed for user-prompt action to bump fees #3132
Comments
Thank you for your useful testing and involvement. May I ask you if you have any links for "stuck EVM transaction" scenarios that you found useful. Thanks in advance. |
I'll point out couple off the top of my head, I guess the get them all you'd need to study the code in the commit I've linked above (and the summary below might not be 100% correct, but it's what I found to work "better than what's currently in master"):
to be fair, I haven't done extensive testing for this change of mine ^ but I will test it out some more over time and fix the rough edges if any are left - but regardless it's clear to me all those things I've listed above need to be addressed for fee-bump mechanism to be useful |
I've noticed there is a typo with displaying "old fee" in UI when user action to bump fees shows up,
I wrote some code to address that - norwnd@adb9438 - but there are also other adjustments in there that are probably useful to consider (I've dug into different "stuck EVM transaction" scenarios while at it and fixed a bunch of issues in there too), feel free to borrow whatever code you want.
The text was updated successfully, but these errors were encountered: