Skip to content

Commit b0700ae

Browse files
jbsvjbsv
committed
fix some lint warnings
1 parent dc4eccc commit b0700ae

File tree

6 files changed

+32
-40
lines changed

6 files changed

+32
-40
lines changed

‎.github/workflows/golangci-lint.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ jobs:
1818
- uses: actions/checkout@v4
1919
- uses: actions/setup-go@v5
2020
with:
21-
go-version: '1.21'
21+
go-version: '1.22'
2222
cache: false
2323
- name: golangci-lint
2424
uses: golangci/golangci-lint-action@v6
2525
with:
2626
# Require: The version of golangci-lint to use.
2727
# When `install-mode` is `binary` (default) the value can be v1.2 or v1.2.3 or `latest` to use the latest version.
2828
# When `install-mode` is `goinstall` the value can be v1.2.3, `latest`, or the hash of a commit.
29-
version: v1.60.3
29+
version: v1.64.5
3030

3131
# Optional: working directory, useful for monorepos
3232
# working-directory: somedir

‎.golangci.yml

+2-3
Original file line numberDiff line numberDiff line change
@@ -119,14 +119,13 @@ linters:
119119
- bidichk # checks for dangerous unicode character sequences
120120
- bodyclose # checks whether HTTP response body is closed successfully
121121
- contextcheck # checks the function whether use a non-inherited context
122+
- copyloopvar # checks for pointers to enclosing loop variables
122123
- cyclop # checks function and package cyclomatic complexity
123124
- dupl # tool for code clone detection
124125
- durationcheck # checks for two durations multiplied together
125126
- errname # checks that sentinel errors are prefixed with the Err and error types are suffixed with the Error
126127
- errorlint # finds code that will cause problems with the error wrapping scheme introduced in Go 1.13
127-
- execinquery # checks query string in Query function which reads your Go src files and warning it finds
128128
- exhaustive # checks exhaustiveness of enum switch statements
129-
- exportloopref # checks for pointers to enclosing loop variables
130129
- forbidigo # forbids identifiers
131130
- funlen # tool for detection of long functions
132131
#- gochecknoglobals # checks that no global variables exist
@@ -159,12 +158,12 @@ linters:
159158
#- rowserrcheck # checks whether Err of rows is checked successfully
160159
#- sqlclosecheck # checks that sql.Rows and sql.Stmt are closed
161160
- stylecheck # is a replacement for golint
162-
- tenv # detects using os.Setenv instead of t.Setenv since Go1.17
163161
#- testpackage # makes you use a separate _test package
164162
- tparallel # detects inappropriate usage of t.Parallel() method in your Go test codes
165163
#- unconvert # removes unnecessary type conversions
166164
- unparam # reports unused function parameters
167165
- usestdlibvars # detects the possibility to use variables/constants from the Go standard library
166+
- usetesting # detects using os.Setenv instead of t.Setenv since Go1.17
168167
#- wastedassign # finds wasted assignment statements
169168
#- whitespace # detects leading and trailing whitespace
170169

‎Makefile

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
tidy:
2-
#go install honnef.co/go/tools/cmd/staticcheck@latest
32
go mod tidy
43

54
generate: tidy
65
go generate ./...
76

87
# Coding style static check.
98
lint: tidy
10-
@go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.3
9+
@go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.5
1110
@go mod tidy
1211
golangci-lint run
1312

‎go.mod

+9-9
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
module go.dedis.ch/kyber/v4
22

3-
go 1.21
3+
go 1.22.0
44

55
require (
6-
github.com/cloudflare/circl v1.3.9
7-
github.com/consensys/gnark-crypto v0.12.1
8-
github.com/jonboulle/clockwork v0.4.0
6+
github.com/cloudflare/circl v1.6.0
7+
github.com/consensys/gnark-crypto v0.16.0
8+
github.com/jonboulle/clockwork v0.5.0
99
github.com/kilic/bls12-381 v0.1.0
10-
github.com/stretchr/testify v1.9.0
10+
github.com/stretchr/testify v1.10.0
1111
go.dedis.ch/fixbuf v1.0.3
1212
go.dedis.ch/protobuf v1.0.11
13-
golang.org/x/crypto v0.21.0
14-
golang.org/x/sys v0.18.0
13+
golang.org/x/crypto v0.33.0
14+
golang.org/x/sys v0.30.0
1515
gopkg.in/yaml.v3 v3.0.1
1616
)
1717

1818
require (
19-
github.com/bits-and-blooms/bitset v1.13.0 // indirect
20-
github.com/consensys/bavard v0.1.13 // indirect
19+
github.com/bits-and-blooms/bitset v1.20.0 // indirect
20+
github.com/consensys/bavard v0.1.29 // indirect
2121
github.com/davecgh/go-spew v1.1.1 // indirect
2222
github.com/kr/text v0.2.0 // indirect
2323
github.com/mmcloughlin/addchain v0.4.0 // indirect

‎go.sum

+17-23
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,18 @@
1-
github.com/bits-and-blooms/bitset v1.13.0/go.mod h1:7hO7Gc7Pp1vODcmWvKMRA9BNmbv6a/7QIWpPxHddWR8=
2-
github.com/bits-and-blooms/bitset v1.14.2 h1:YXVoyPndbdvcEVcseEovVfp0qjJp7S+i5+xgp/Nfbdc=
3-
github.com/bits-and-blooms/bitset v1.14.2/go.mod h1:7hO7Gc7Pp1vODcmWvKMRA9BNmbv6a/7QIWpPxHddWR8=
4-
github.com/cloudflare/circl v1.3.9/go.mod h1:PDRU+oXvdD7KCtgKxW95M5Z8BpSCJXQORiZFnBQS5QU=
5-
github.com/cloudflare/circl v1.5.0 h1:hxIWksrX6XN5a1L2TI/h53AGPhNHoUBo+TD1ms9+pys=
6-
github.com/cloudflare/circl v1.5.0/go.mod h1:uddAzsPgqdMAYatqJ0lsjX1oECcQLIlRpzZh3pJrofs=
7-
github.com/consensys/bavard v0.1.13 h1:oLhMLOFGTLdlda/kma4VOJazblc7IM5y5QPd2A/YjhQ=
8-
github.com/consensys/bavard v0.1.13/go.mod h1:9ItSMtA/dXMAiL7BG6bqW2m3NdSEObYWoH223nGHukI=
9-
github.com/consensys/gnark-crypto v0.12.1/go.mod h1:v2Gy7L/4ZRosZ7Ivs+9SfUDr0f5UlG+EM5t7MPHiLuY=
10-
github.com/consensys/gnark-crypto v0.14.0 h1:DDBdl4HaBtdQsq/wfMwJvZNE80sHidrK3Nfrefatm0E=
11-
github.com/consensys/gnark-crypto v0.14.0/go.mod h1:CU4UijNPsHawiVGNxe9co07FkzCeWHHrb1li/n1XoU0=
1+
github.com/bits-and-blooms/bitset v1.20.0 h1:2F+rfL86jE2d/bmw7OhqUg2Sj/1rURkBn3MdfoPyRVU=
2+
github.com/bits-and-blooms/bitset v1.20.0/go.mod h1:7hO7Gc7Pp1vODcmWvKMRA9BNmbv6a/7QIWpPxHddWR8=
3+
github.com/cloudflare/circl v1.6.0 h1:cr5JKic4HI+LkINy2lg3W2jF8sHCVTBncJr5gIIq7qk=
4+
github.com/cloudflare/circl v1.6.0/go.mod h1:uddAzsPgqdMAYatqJ0lsjX1oECcQLIlRpzZh3pJrofs=
5+
github.com/consensys/bavard v0.1.29 h1:fobxIYksIQ+ZSrTJUuQgu+HIJwclrAPcdXqd7H2hh1k=
6+
github.com/consensys/bavard v0.1.29/go.mod h1:k/zVjHHC4B+PQy1Pg7fgvG3ALicQw540Crag8qx+dZs=
7+
github.com/consensys/gnark-crypto v0.16.0 h1:8Dl4eYmUWK9WmlP1Bj6je688gBRJCJbT8Mw4KoTAawo=
8+
github.com/consensys/gnark-crypto v0.16.0/go.mod h1:Ke3j06ndtPTVvo++PhGNgvm+lgpLvzbcE2MqljY7diU=
129
github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
1310
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
1411
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
1512
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
1613
github.com/google/subcommands v1.2.0/go.mod h1:ZjhPrFU+Olkh9WazFPsl27BQ4UPiG37m3yTrtFlrHVk=
17-
github.com/jonboulle/clockwork v0.4.0 h1:p4Cf1aMWXnXAUh8lVfewRBx1zaTSYKrKMF2g3ST4RZ4=
18-
github.com/jonboulle/clockwork v0.4.0/go.mod h1:xgRqUGwRcjKCO1vbZUEtSLrqKoPSsUpK7fnezOII0kc=
14+
github.com/jonboulle/clockwork v0.5.0 h1:Hyh9A8u51kptdkR+cqRpT1EebBwTn1oK9YfGYbdFz6I=
15+
github.com/jonboulle/clockwork v0.5.0/go.mod h1:3mZlmanh0g2NDKO5TWZVJAfofYk64M7XN3SzBPjZF60=
1916
github.com/kilic/bls12-381 v0.1.0 h1:encrdjqKMEvabVQ7qYOKu1OvhqpK4s47wDYtNiPtlp4=
2017
github.com/kilic/bls12-381 v0.1.0/go.mod h1:vDTTHJONJ6G+P2R74EhnyotQDTliQDnFEwhdmfzw1ig=
2118
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
@@ -29,13 +26,12 @@ github.com/mmcloughlin/addchain v0.4.0/go.mod h1:A86O+tHqZLMNO4w6ZZ4FlVQEadcoqky
2926
github.com/mmcloughlin/profile v0.1.1/go.mod h1:IhHD7q1ooxgwTgjxQYkACGA77oFTDdFVejUS1/tS/qU=
3027
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
3128
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
29+
github.com/rogpeppe/go-internal v1.9.0 h1:73kH8U+JUqXU8lRuOHeVHaa/SZPifC7BkcraZVejAe8=
3230
github.com/rogpeppe/go-internal v1.9.0/go.mod h1:WtVeX8xhTBvf0smdhujwtBcq4Qrzq/fJaraNFVN+nFs=
33-
github.com/rogpeppe/go-internal v1.13.1 h1:KvO1DLK/DRN07sQ1LQKScxyZJuNnedQ5/wKSR38lUII=
34-
github.com/rogpeppe/go-internal v1.13.1/go.mod h1:uMEvuHeurkdAXX61udpOXGD/AzZDWNMNyH2VO9fmH0o=
3531
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
3632
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
37-
github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
38-
github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
33+
github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
34+
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
3935
go.dedis.ch/fixbuf v1.0.3 h1:hGcV9Cd/znUxlusJ64eAlExS+5cJDIyTyEG+otu5wQs=
4036
go.dedis.ch/fixbuf v1.0.3/go.mod h1:yzJMt34Wa5xD37V5RTdmp38cz3QhMagdGoem9anUalw=
4137
go.dedis.ch/kyber/v3 v3.0.4/go.mod h1:OzvaEnPvKlyrWyp3kGXlFdp7ap1VC6RkZDTaPikqhsQ=
@@ -46,14 +42,12 @@ go.dedis.ch/protobuf v1.0.7/go.mod h1:pv5ysfkDX/EawiPqcW3ikOxsL5t+BqnV6xHSmE79KI
4642
go.dedis.ch/protobuf v1.0.11 h1:FTYVIEzY/bfl37lu3pR4lIj+F9Vp1jE8oh91VmxKgLo=
4743
go.dedis.ch/protobuf v1.0.11/go.mod h1:97QR256dnkimeNdfmURz0wAMNVbd1VmLXhG1CrTYrJ4=
4844
golang.org/x/crypto v0.0.0-20190123085648-057139ce5d2b/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4=
49-
golang.org/x/crypto v0.21.0/go.mod h1:0BP7YvVV9gBbVKyeTG0Gyn+gZm94bibOW5BjDEYAOMs=
50-
golang.org/x/crypto v0.29.0 h1:L5SG1JTTXupVV3n6sUqMTeWbjAyfPwoda2DLX8J8FrQ=
51-
golang.org/x/crypto v0.29.0/go.mod h1:+F4F4N5hv6v38hfeYwTdx20oUvLLc+QfrE9Ax9HtgRg=
45+
golang.org/x/crypto v0.33.0 h1:IOBPskki6Lysi0lo9qQvbxiQ+FvsCC/YWOecCHAixus=
46+
golang.org/x/crypto v0.33.0/go.mod h1:bVdXmD7IV/4GdElGPozy6U7lWdRXA4qyRVGJV57uQ5M=
5247
golang.org/x/sys v0.0.0-20190124100055-b90733256f2e/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
5348
golang.org/x/sys v0.0.0-20201101102859-da207088b7d1/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
54-
golang.org/x/sys v0.18.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
55-
golang.org/x/sys v0.27.0 h1:wBqf8DvsY9Y/2P8gAfPDEYNuS30J4lPHJxXSb/nJZ+s=
56-
golang.org/x/sys v0.27.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
49+
golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
50+
golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
5751
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
5852
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
5953
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=

‎share/dkg/pedersen/dkg_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ type TestNode struct {
2626
proto *Protocol
2727
phaser *TimePhaser
2828
board *TestBoard
29-
clock clock.FakeClock
29+
clock *clock.FakeClock
3030
}
3131

3232
func NewTestNode(s Suite, index int) *TestNode {

0 commit comments

Comments
 (0)