fix updateby gen

Author: niloc132

engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/fill/BooleanFillByOperator.java

@@ -13,6 +13,7 @@
 import io.deephaven.engine.table.impl.sources.BooleanArraySource;
 import io.deephaven.engine.table.impl.sources.BooleanSparseArraySource;
 import io.deephaven.engine.table.WritableColumnSource;
+import io.deephaven.util.BooleanUtils;
 
 import io.deephaven.base.verify.Assert;
 import io.deephaven.chunk.ByteChunk;
@@ -21,10 +22,8 @@
 import io.deephaven.engine.table.impl.MatchPair;
 import io.deephaven.engine.table.impl.updateby.UpdateByOperator;
 import io.deephaven.engine.table.impl.updateby.internal.BaseByteUpdateByOperator;
-import io.deephaven.util.BooleanUtils;
 import org.jetbrains.annotations.NotNull;
 
-import static io.deephaven.util.BooleanUtils.NULL_BOOLEAN_AS_BYTE;
 
 public class BooleanFillByOperator extends BaseByteUpdateByOperator {
     // region extra-fields
@@ -47,7 +46,7 @@ public void push(int pos, int count) {
             Assert.eq(count, "push count", 1);
 
             byte val = booleanValueChunk.get(pos);
-            if (!BooleanUtils.isNull(val)) {
+            if(BooleanUtils.isNull(val)) {
                 curVal = val;
             }
         }
@@ -81,7 +80,7 @@ public UpdateByOperator.Context makeUpdateContext(final int affectedChunkSize, f
     // region extra-methods
     @Override
     protected byte getNullValue() {
-        return NULL_BOOLEAN_AS_BYTE;
+        return BooleanUtils.NULL_BOOLEAN_AS_BYTE;
     }
     @Override
     protected WritableColumnSource<Byte> makeSparseSource() {

replication/static/src/main/java/io/deephaven/replicators/ReplicateUpdateBy.java

@@ -326,12 +326,14 @@ private static void fixupByteBase(String byteResult) throws IOException {
     private static void fixupBoolean(String boolResult) throws IOException {
         final File objectFile = new File(boolResult);
         List<String> lines = FileUtils.readLines(objectFile, Charset.defaultCharset());
+        lines = removeImport(lines, "import static io.deephaven.util.QueryConstants.NULL_BOOLEAN;");
         lines = addImport(lines, "import io.deephaven.engine.table.ColumnSource;",
                 "import java.util.Map;",
                 "import java.util.Collections;",
                 "import io.deephaven.engine.table.impl.sources.BooleanArraySource;",
                 "import io.deephaven.engine.table.impl.sources.BooleanSparseArraySource;",
-                "import io.deephaven.engine.table.WritableColumnSource;");
+                "import io.deephaven.engine.table.WritableColumnSource;",
+                "import io.deephaven.util.BooleanUtils;");
 
         lines = globalReplacements(lines,
                 "BaseBooleanUpdateByOperator", "BaseByteUpdateByOperator",
@@ -343,14 +345,13 @@ private static void fixupBoolean(String boolResult) throws IOException {
                 "boolean previousVal", "byte previousVal",
                 "boolean currentVal", "byte currentVal",
                 "BooleanChunk", "ByteChunk",
-                "NULL_BOOLEAN", "NULL_BOOLEAN_AS_BYTE");
-        lines = globalReplacements(lines,
-                "!BooleanPrimitives\\.isNull\\(currentVal\\)", "currentVal != NULL_BOOLEAN_AS_BYTE");
+                "val != NULL_BOOLEAN", "BooleanUtils.isNull(val)"
+        );
         lines = replaceRegion(lines, "extra-methods",
                 Collections.singletonList(
                         "    @Override\n" +
                                 "    protected byte getNullValue() {\n" +
-                                "        return NULL_BOOLEAN_AS_BYTE;\n" +
+                                "        return BooleanUtils.NULL_BOOLEAN_AS_BYTE;\n" +
                                 "    }\n" +
                                 "    @Override\n" +
                                 "    protected WritableColumnSource<Byte> makeSparseSource() {\n" +