fix: DH-18803: Add qst Type find support for componentType #6667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the needed, centralized logic for adapting to qst Type when componentType is not null. This allows downstream callers, such as the Sql adapter layer, to correctly construct the appropriate Types.
devinrsmith
added
NoDocumentationNeeded
ReleaseNotesNeeded
nbauernfeind
reviewed
Mar 4, 2025
|
|
||
| @Override | ||
| public String visit(BooleanType booleanType) { | ||
| return null; |
There was a problem hiding this comment.
Is it possible (or necessary?) to map this to ObjectVector<Boolean> -- this is what a groupBy will do for both boxed and unboxed booleans.
There was a problem hiding this comment.
So, this is mostly a modelling Q; ObjectVector<Integer> is not the same as IntVector. In that vain, ObjectVector<Boolean> is a valid io.deephaven.qst.type.GenericVectorType, but there is no io.deephaven.qst.type.PrimitiveVectorType equivalent (just as there is no BoolVector).
nbauernfeind
approved these changes
Mar 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the needed, centralized logic for adapting to qst Type when componentType is not null. This allows downstream callers, such as the Sql adapter layer, to correctly construct the appropriate Types.