chore: Remove unnecessary dependency, add missing direct dependencies #6670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
build
NoDocumentationNeeded
dependencies
devinrsmith
approved these changes
Mar 3, 2025
nbauernfeind
approved these changes
Mar 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authentication unnecessarily depends on our generated proto/grpc types, which means all manner of other projects must wait for our proto project to build, and pick up all sorts of transitive dependencies. This patch removes that build dependency (improving build parallelization slightly), and also identified various direct dependencies that should have previously been declared.
This mostly comes from grpc-api - for reasons that I don't yet understand, even though grpc-api declares guava to be an
implementationdependency, when grpc-api itself is anapidependency this causes Gradle to pick up transitive guava as an implementation dependency, so all downstream projects end up getting it on their classpath for free. The jsr305 dependency at least is explicitly declared asapiin grpc-api, so that one makes sense.