Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary dependency, add missing direct dependencies #6670

Merged
merged 2 commits into from
Mar 3, 2025
Merged

chore: Remove unnecessary dependency, add missing direct dependencies #6670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5023dd8
chore: Remove unnecessary dependency, add missing direct dependencies
niloc132 Mar 2, 2025
530a579
Fix an issue with platform-defined dependencies
niloc132 Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Integrations/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ dependencies {
implementation project(':log-factory')
implementation project(":util-thread")
implementation libs.commons.lang3
implementation libs.google.findbugs.jsr305

testImplementation project(':engine-test-utils')
testImplementation project(path: ':Base', configuration: 'tests')
Expand Down
1 change: 0 additions & 1 deletion authentication/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ plugins {
description 'authentication: Deephaven authentication and identity'

dependencies {
api project(':proto:proto-backplane-grpc')
implementation project(':log-factory')
implementation project(':Configuration')

Expand Down
2 changes: 2 additions & 0 deletions authentication/example-providers/mtls/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,6 @@ plugins {

dependencies {
shadow project(':grpc-java:grpc-mtls')
shadow platform(libs.grpc.bom)
shadow libs.grpc.api
}
2 changes: 2 additions & 0 deletions authorization-codegen/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,6 @@ dependencies {
implementation libs.grpc.services

implementation libs.squareup.javapoet

implementation libs.protobuf.java
}
8 changes: 7 additions & 1 deletion buildSrc/src/main/groovy/io.deephaven.java-shadow-publishing-conventions.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,20 @@ PublishingTools.setupPublications(project) { publication ->
def dependenciesNode = root.appendNode('dependencies')

project.configurations.shadow.allDependencies.each {
if ((it instanceof ProjectDependency) || ! (it instanceof SelfResolvingDependency)) {
if ((it instanceof ProjectDependency)) {
def dependencyNode = dependenciesNode.appendNode('dependency')
dependencyNode.appendNode('groupId', it.group)
BasePluginConvention base = it.dependencyProject.convention.getPlugin(BasePluginConvention)

dependencyNode.appendNode('artifactId', base.archivesBaseName)
dependencyNode.appendNode('version', it.version)
dependencyNode.appendNode('scope', 'runtime')
} else if (! (it instanceof SelfResolvingDependency)) {
def dependencyNode = dependenciesNode.appendNode('dependency')
dependencyNode.appendNode('groupId', it.group)
dependencyNode.appendNode('artifactId', it.name)
dependencyNode.appendNode('version', it.version)
dependencyNode.appendNode('scope', 'runtime')
}
}
}
Expand Down
2 changes: 2 additions & 0 deletions extensions/iceberg/s3/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ dependencies {
// actually calls it?), but we need to be able to compile against it to implement AwsClientFactory
compileOnly libs.awssdk.kms

implementation libs.guava

compileOnly libs.autoservice
annotationProcessor libs.autoservice.compiler

Expand Down
2 changes: 2 additions & 0 deletions extensions/parquet/table/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ dependencies {
implementation libs.jackson.dataformat.yaml
implementation libs.jackson.datatype.jdk8

implementation libs.guava

compileOnly project(':util-immutables')
annotationProcessor libs.immutables.value

Expand Down
1 change: 1 addition & 0 deletions extensions/performance/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ dependencies {
implementation project(':DHProcess')
implementation project(':engine-table')
implementation project(':Plot')
implementation libs.guava
compileOnly libs.autoservice
annotationProcessor libs.autoservice.compiler
implementation libs.groovy
Expand Down
2 changes: 2 additions & 0 deletions web/client-api/client-api.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ dependencies {

js project(path: ':proto:raw-js-openapi', configuration: 'js')

implementation libs.guava

testImplementation libs.junit4
testImplementation libs.selenium.remote.driver

Expand Down