Skip to content

Commit

Permalink
Use gradle property to control signing.required (#123)
Browse files Browse the repository at this point in the history
Adds gradle property signingRequired. This allows developers to use `./gradlew publishToMavenLocal` instead of `./gradlew publishToMavenLocal -x signMavenJavaPublication`.

See deephaven/deephaven-core#3846

See gradle/gradle#24456
  • Loading branch information
devinrsmith authored May 22, 2023
1 parent 19893fd commit 3605edc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@ jobs:
ORG_GRADLE_PROJECT_ossrhPassword: ${{ secrets.SONATYPE_PASSWORD }}
ORG_GRADLE_PROJECT_signingKey: ${{ secrets.CI_AT_DEEPHAVEN_KEY }}
ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.CI_AT_DEEPHAVEN_PASSWORD }}
ORG_GRADLE_PROJECT_signingRequired: true
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ publishing {
}

signing {
required = "true" == findProperty('signingRequired')
sign publishing.publications.mavenJava
String signingKey = findProperty('signingKey')
String signingPassword = findProperty('signingPassword')
Expand Down

0 comments on commit 3605edc

Please sign in to comment.