From 3605edca1825f0ba1eb79e2d30429c3136b40de6 Mon Sep 17 00:00:00 2001 From: Devin Smith Date: Mon, 22 May 2023 08:23:20 -0700 Subject: [PATCH] Use gradle property to control signing.required (#123) Adds gradle property signingRequired. This allows developers to use `./gradlew publishToMavenLocal` instead of `./gradlew publishToMavenLocal -x signMavenJavaPublication`. See https://github.com/deephaven/deephaven-core/pull/3846 See https://github.com/gradle/gradle/issues/24456 --- .github/workflows/publish.yml | 1 + .../groovy/io.deephaven.csv.java-publishing-conventions.gradle | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index f7913ad1..03052c20 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -44,3 +44,4 @@ jobs: ORG_GRADLE_PROJECT_ossrhPassword: ${{ secrets.SONATYPE_PASSWORD }} ORG_GRADLE_PROJECT_signingKey: ${{ secrets.CI_AT_DEEPHAVEN_KEY }} ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.CI_AT_DEEPHAVEN_PASSWORD }} + ORG_GRADLE_PROJECT_signingRequired: true diff --git a/buildSrc/src/main/groovy/io.deephaven.csv.java-publishing-conventions.gradle b/buildSrc/src/main/groovy/io.deephaven.csv.java-publishing-conventions.gradle index 858f2c14..fc7c5c0c 100644 --- a/buildSrc/src/main/groovy/io.deephaven.csv.java-publishing-conventions.gradle +++ b/buildSrc/src/main/groovy/io.deephaven.csv.java-publishing-conventions.gradle @@ -80,6 +80,7 @@ publishing { } signing { + required = "true" == findProperty('signingRequired') sign publishing.publications.mavenJava String signingKey = findProperty('signingKey') String signingPassword = findProperty('signingPassword')