fix: Proxy model appears partition even if original model is not #2373
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2373 +/- ##
========================================
Coverage 46.80% 46.80%
========================================
Files 710 710
Lines 39224 39226 +2
Branches 9789 9975 +186
========================================
+ Hits 18357 18358 +1
- Misses 20856 20857 +1
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dgodinez-dh
requested review from
a team and
vbabich
and removed request for
a team
| @@ -300,6 +301,10 @@ class IrisGridProxyModel extends IrisGridModel implements PartitionedGridModel { | |||
| !isPartitionedGridModelProvider(this.originalModel) || | |||
| !this.originalModel.isPartitionRequired | |||
| ) { | |||
| if (!isPartitionedGridModel(this.originalModel)) { | |||
| // @ts-expect-error If the original model has an undefined partitionConfig return undefined to make the proxy model also return false in isPartitionedGridModel | |||
There was a problem hiding this comment.
Would it be difficult to change the return type instead of suppressing the error in partitionConfig and isPartitionRequired?
There was a problem hiding this comment.
It could be changed, but I think it is correct as it is. A real PartitionedGridModel should never return undefined for these values, and I think code using a real PartitionedGridModel should not need to worry about checking for undefined.
https://deephaven.atlassian.net/browse/DH-18545
IrisGridProxyModelis aPartitionedGridModeland always returnstrueforisPartitionedGridModelProviderandisPartitionedGridModel.This fix changes the proxy return values so those methods return
falseif they would returnfalsefor the original model.