fix: Don't use innerHTML to populate drag item (DH-18645) #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We were using `innerHTML` with the text of the name of the file to create the drag placeholder content - Instead, inject the name using `innerText` so it is escaped properly - Tested by naming a file `<img src=q onerror=prompt(1)>.py`, and then attempting to move it. It no longer triggered the popup.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2378 +/- ##
==========================================
- Coverage 46.80% 46.79% -0.01%
==========================================
Files 710 710
Lines 39226 39229 +3
Branches 9975 9791 -184
==========================================
Hits 18358 18358
- Misses 20814 20860 +46
+ Partials 54 11 -43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattrunyon
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
PR Overview
This PR addresses a potential XSS vulnerability by replacing the use of innerHTML with innerText when creating the drag placeholder content in the file explorer.
- Replaces innerHTML assignment with safe DOM manipulation using createElement and innerText
- Ensures proper escaping of file names in the drag placeholder to mitigate script injection attacks
Reviewed Changes
| File | Description |
|---|---|
| packages/file-explorer/src/FileList.tsx | Updates drag placeholder creation to use innerText for escaping |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
innerHTMLwith the text of the name of the file to create the drag placeholder contentinnerTextso it is escaped properly<img src=q onerror=prompt(1)>.py, and then attempting to move it. It no longer triggered the popup.