Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Playwright to v1.51 #2307

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
52 changes: 26 additions & 26 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"e2e": "playwright test",
"e2e:codegen": "playwright codegen http://localhost:4000",
"e2e:headed": "playwright test --project=chromium --debug --ignore-snapshots",
"e2e:update-snapshots": "playwright test --update-snapshots",
"e2e:update-snapshots": "playwright test --update-snapshots=changed",
"e2e:docker": "./tests/docker-scripts/run.sh web-ui-tests",
"e2e:update-ci-snapshots": "./tests/docker-scripts/run.sh web-ui-update-snapshots"
},
Expand All @@ -72,7 +72,7 @@
"@deephaven/tsconfig": "file:../tsconfig",
"@deephaven/utils": "file:../utils",
"@fortawesome/fontawesome-common-types": "^6.1.1",
"@playwright/test": "1.44.0",
"@playwright/test": "1.50.1",
"@testing-library/jest-dom": "^5.16.4",
"@testing-library/react": "^12.1.3",
"@testing-library/react-hooks": "^8.0.1",
Expand Down
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kerning seems to be enabled, even though we should be disabling it in font-kerning: none !important. Is the Playwright.css not being loaded?

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/context-menu.spec.ts-snapshots/go-to-1-chromium-linux.png
Binary file modified tests/context-menu.spec.ts-snapshots/go-to-1-webkit-linux.png
Binary file modified tests/context-menu.spec.ts-snapshots/go-to-2-chromium-linux.png
Binary file modified tests/context-menu.spec.ts-snapshots/go-to-2-firefox-linux.png
Binary file modified tests/context-menu.spec.ts-snapshots/go-to-2-webkit-linux.png
Binary file modified tests/context-menu.spec.ts-snapshots/go-to-3-chromium-linux.png
Binary file modified tests/context-menu.spec.ts-snapshots/go-to-3-firefox-linux.png
Binary file modified tests/context-menu.spec.ts-snapshots/go-to-3-webkit-linux.png
Binary file modified tests/context-menu.spec.ts-snapshots/sort-by-1-webkit-linux.png
Binary file modified tests/context-menu.spec.ts-snapshots/sort-by-2-webkit-linux.png
Binary file modified tests/context-menu.spec.ts-snapshots/sort-by-3-webkit-linux.png
2 changes: 1 addition & 1 deletion tests/docker-scripts/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN cd /tmp/web-client-ui && cp --parents ./packages/*/package.json /work/
# syntax=docker/dockerfile:1
# Dockerfile for updating the snapshots.
# Expects to be run from the root of the web-client-ui repo
FROM mcr.microsoft.com/playwright:v1.44.0-jammy AS playwright
FROM mcr.microsoft.com/playwright:v1.50.1-noble AS playwright
WORKDIR /work/

# Update packages list and install some build tools
Expand Down
Binary file modified tests/styleguide.spec.ts-snapshots/buttons-inline-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/chart-colors-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/charts-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/charts-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/colors-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/colors-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/context-menus-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/context-menus-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/dialog-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/dialog-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/dropdown-menus-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/editors-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/editors-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/error-views-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/golden-layout-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grid-colors-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-async-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-async-firefox-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-async-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-grid-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-grid-firefox-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-grid-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-iris-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-iris-firefox-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-iris-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-static-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-static-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-tree-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-tree-firefox-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/grids-tree-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/icons-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/icons-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/inputs-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/inputs-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/links-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/links-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/list-views-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/list-views-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/modals-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/modals-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/navigations-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/navigations-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/pickers-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/pickers-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/progress-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/progress-webkit-linux.png
Loading
Loading