Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid exceeding call stack when exporting logs with large number of queries #2382

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

dgodinez-dh
Copy link
Contributor

@dgodinez-dh dgodinez-dh requested a review from mofojed March 6, 2025 20:18
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.80%. Comparing base (d44370b) to head (0de176b).

Files with missing lines Patch % Lines
packages/log/src/LogExport.ts 75.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2382   +/-   ##
=======================================
  Coverage   46.79%   46.80%           
=======================================
  Files         710      710           
  Lines       39234    39240    +6     
  Branches     9976     9978    +2     
=======================================
+ Hits        18361    18365    +4     
- Misses      20819    20821    +2     
  Partials       54       54           
Flag Coverage Δ
unit 46.80% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dgodinez-dh dgodinez-dh merged commit 3c2c8cf into deephaven:main Mar 7, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants