Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: misguiding documentation for setting preferred factory functions #381

Open
patryk-kowalski-ds opened this issue Mar 1, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@patryk-kowalski-ds
Copy link

patryk-kowalski-ds commented Mar 1, 2025

What happened?

https://ragbits.deepsense.ai/how-to/core/component_preferrences/#llm-configuration

The example setting for llm factory (text = "my_project.get_text_llm") suggests the function (pythonpath) should be linked by dots, while it needs a colon before function name to work with ragbits (like described in the docstring of subclass_by_factory - factory_path: A string representing the path to the factory in the format of "module.submodule:factory_name".)

Suggestion - just fix the examples to my_project:get_text_llm

How can we reproduce it?

Relevant log output

@patryk-kowalski-ds patryk-kowalski-ds added the bug Something isn't working label Mar 1, 2025
@patryk-kowalski-ds patryk-kowalski-ds changed the title Misguiding documentation for setting preferred factory functions bug: misguiding documentation for setting preferred factory functions Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant