Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add (optional) config_model field for all WithConstructionConfig objects #237

Closed
kdziedzic68 opened this issue Dec 5, 2024 · 1 comment
Closed

feat: add (optional) config_model field for all WithConstructionConfig objects #237

kdziedzic68 opened this issue Dec 5, 2024 · 1 comment
Assignees
@kzamlynska
Labels
feature New feature or request
Milestone
Ragbits 1.0.0

Comments

@kdziedzic68
Copy link
Collaborator

Feature description

Each object inheriting from WithConstructionConfig should have additional class variable: config_model (None in base class).

default implementation of from_config should:

  • check if class has non-empty config_model
  • if so validate the config with respect to it
  • instantiate the object

Motivation

The process would simplify objects instantiation - the configs would be validated under the hood

Additional context

No response
@kdziedzic68 kdziedzic68 added the feature New feature or request label Dec 5, 2024
@kdziedzic68 kdziedzic68 moved this to Backlog in ragbits Dec 5, 2024
@kdziedzic68 kdziedzic68 mentioned this issue Dec 5, 2024
Merged
@mhordynski mhordynski moved this from Backlog to Ready in ragbits Jan 20, 2025
@mhordynski mhordynski added this to the 0 / Maintenance milestone Feb 12, 2025
@kzamlynska kzamlynska self-assigned this Mar 3, 2025
@kzamlynska kzamlynska moved this from Ready to In Progress in ragbits Mar 3, 2025
@kzamlynska kzamlynska moved this from In Progress to Ready in ragbits Mar 5, 2025
@kzamlynska kzamlynska removed their assignment Mar 5, 2025
@kzamlynska kzamlynska self-assigned this Mar 13, 2025
@kzamlynska kzamlynska moved this from Ready to In Progress in ragbits Mar 13, 2025
@kzamlynska kzamlynska mentioned this issue Mar 17, 2025
Closed
kzamlynska added a commit that referenced this issue Mar 19, 2025
@kzamlynska
Merge branch 'main' into kz/#237-feat-optional-config-model
b66f742 
# Conflicts:
#	packages/ragbits-document-search/CHANGELOG.md
kzamlynska added a commit that referenced this issue Mar 19, 2025
@kzamlynska
Merge branch 'main' into kz/#237-feat-optional-config-model
590e807 
# Conflicts:
#	packages/ragbits-evaluate/CHANGELOG.md
@kzamlynska kzamlynska moved this from In Progress to In review in ragbits Mar 20, 2025
kzamlynska added a commit that referenced this issue Mar 20, 2025
@kzamlynska
Merge branch 'main' into kz/#237-feat-optional-config-model
5367b49 
# Conflicts:
#	packages/ragbits-document-search/CHANGELOG.md
kzamlynska added a commit that referenced this issue Mar 21, 2025
@kzamlynska
Merge branch 'main' into kz/#237-feat-optional-config-model
cd2d657 
# Conflicts:
#	packages/ragbits-document-search/CHANGELOG.md
kzamlynska added a commit that referenced this issue Mar 24, 2025
@kzamlynska
Merge branch 'main' into kz/#237-feat-optional-config-model
1f494ef 
# Conflicts:
#	packages/ragbits-document-search/src/ragbits/document_search/_main.py
#	packages/ragbits-evaluate/CHANGELOG.md
kzamlynska added a commit that referenced this issue Mar 25, 2025
@kzamlynska
Merge branch 'main' into kz/#237-feat-optional-config-model
54eb802 
# Conflicts:
#	packages/ragbits-core/CHANGELOG.md
#	packages/ragbits-core/src/ragbits/core/vector_stores/base.py
kzamlynska added a commit that referenced this issue Mar 25, 2025
@kzamlynska
Merge branch 'main' into kz/#237-feat-optional-config-model
507e6a0 
# Conflicts:
#	packages/ragbits-document-search/CHANGELOG.md
@kzamlynska kzamlynska moved this from In review to Won't fix in ragbits Mar 25, 2025
@kzamlynska
Copy link
Collaborator

After discussion we decided implementing this feature requires too much work for not too big benefits.

@github-project-automation github-project-automation bot moved this from Won't fix to Done in ragbits Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kzamlynska kzamlynska

Labels
feature New feature or request
Projects
ragbits
Status: Done
Milestone
Ragbits 1.0.0
Development

Successfully merging a pull request may close this issue.

feat: optional config_model in WithConstructionConfig deepsense-ai/ragbits
3 participants
@mhordynski @kdziedzic68 @kzamlynska