Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SDK use of ai.deepsense.deeplang.doperables.Transformer #23

Closed
metasim opened this issue Mar 6, 2018 · 4 comments
Closed

Allow SDK use of ai.deepsense.deeplang.doperables.Transformer #23

metasim opened this issue Mar 6, 2018 · 4 comments

Comments

@metasim
Copy link
Contributor

metasim commented Mar 6, 2018

Transformer and the associated TransformerAsOperation classes serve a useful role in abstracting over the construction of transformers. SDK users can not build against them because the abstract method Transformer._transform is marked as private[deeplang]. Would the project consider agging it and _transformSchema as protected instead?

@metasim
Copy link
Contributor Author

metasim commented Mar 6, 2018

I'm happy to submit a PR for this if amenable.

@jaroslaw-osmanski
Copy link

Please submit a PR. It will be accepted.

@metasim
Copy link
Contributor Author

metasim commented Mar 15, 2018

Turns out that just changing the private[deeplang] to protected doesn't work, because TransformerWrapper and StringIndexingWrapperModel call the _transform and _transformSchema methods directly on the entities they wrap. As best I know, there's no way in Scala to say access is either protected or private[xyz].

@metasim
Copy link
Contributor Author

metasim commented May 21, 2018

Addressed in #36

@metasim metasim closed this as completed May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants