-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Inputer as DOperation #68
Open
jaroslaw-osmanski
wants to merge
3
commits into
spark-2.2
Choose a base branch
from
add-imputer
base: spark-2.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,7 @@ | |
sbt_type = 'sbt' | ||
|
||
|
||
spark_version = "2.1.1" | ||
spark_version = "2.2.0" | ||
hadoop_version = "2.7" | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule seahorse-sdk-example
updated
from 01c64e to 710d70
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
...workflow-executor/deeplang/src/main/scala/ai/deepsense/deeplang/doperations/Imputer.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
/** | ||
* Copyright (c) 2016, CodiLime Inc. | ||
*/ | ||
package ai.deepsense.deeplang.doperations | ||
|
||
import scala.language.reflectiveCalls | ||
import scala.reflect.runtime.universe.TypeTag | ||
|
||
import ai.deepsense.commons.models.Id | ||
import ai.deepsense.commons.utils.Version | ||
import ai.deepsense.deeplang._ | ||
import ai.deepsense.deeplang.documentation.OperationDocumentation | ||
import ai.deepsense.deeplang.doperables.Transformer | ||
import ai.deepsense.deeplang.doperables.dataframe.DataFrame | ||
import ai.deepsense.deeplang.doperations.InputerTransformer.{Mean, Strategy} | ||
import ai.deepsense.deeplang.params.choice.Choice | ||
import ai.deepsense.deeplang.params.{ColumnSelectorParam, Param} | ||
import ai.deepsense.deeplang.params.selections.{MultipleColumnSelection, NameColumnSelection} | ||
import ai.deepsense.deeplang.params.wrappers.spark.{ChoiceParamWrapper, ParamsWithSparkWrappers} | ||
import org.apache.spark.ml | ||
import org.apache.spark.ml.feature.{Imputer => SparkImputer} | ||
import org.apache.spark.sql.types.StructType | ||
|
||
|
||
|
||
object InputerTransformer { | ||
sealed abstract class Strategy(override val name: String) extends Choice { | ||
override val params: Array[Param[_]] = Array() | ||
|
||
override val choiceOrder: List[Class[_ <: Choice]] = List( | ||
classOf[Mean], | ||
classOf[Median] | ||
) | ||
} | ||
case class Mean() extends Strategy("mean") | ||
case class Median() extends Strategy("median") | ||
} | ||
|
||
|
||
class InputerTransformer extends Transformer with ParamsWithSparkWrappers { | ||
|
||
val selectedColumns = ColumnSelectorParam( | ||
name = "selected columns", | ||
description = Some("Columns to complete missing values in."), | ||
portIndex = 0) | ||
|
||
def getSelectedColumns: MultipleColumnSelection = $(selectedColumns) | ||
|
||
def setSelectedColumns(value: MultipleColumnSelection): this.type = | ||
set(selectedColumns, value) | ||
|
||
def setSelectedColumns(retainedColumns: Seq[String]): this.type = | ||
setSelectedColumns( | ||
MultipleColumnSelection( | ||
Vector(NameColumnSelection(retainedColumns.toSet)), | ||
excluding = false)) | ||
|
||
val strategy = new ChoiceParamWrapper[ | ||
ml.param.Params { val strategy: ml.param.Param[String] }, Strategy]( | ||
name = "strategy", | ||
description = Some("Algorithm used to compute missing value"), | ||
sparkParamGetter = _.strategy) | ||
setDefault(strategy, Mean()) | ||
|
||
override val params: Array[Param[_]] = Array(selectedColumns, strategy) | ||
|
||
|
||
|
||
override def applyTransform(ctx: ExecutionContext, df: DataFrame): DataFrame = { | ||
val columns = df.getColumnNames(getSelectedColumns) | ||
val inputer = new SparkImputer() | ||
.setInputCols(columns.toArray) | ||
.setOutputCols(columns.toArray) | ||
val sparkParams = | ||
sparkParamMap(inputer, df.sparkDataFrame.schema) | ||
|
||
val imputerModel = inputer.fit(df.sparkDataFrame, sparkParams) | ||
val res = imputerModel.transform(df.sparkDataFrame).toDF() | ||
DataFrame.fromSparkDataFrame(res) | ||
} | ||
|
||
override def applyTransformSchema(schema: StructType): Option[StructType] = { | ||
Some(schema) | ||
} | ||
} | ||
|
||
|
||
class Imputer extends TransformerAsOperation[InputerTransformer] with OperationDocumentation { | ||
override val id: Id = "37d8ce21-0aa9-4448-8fb0-defb58c5e53f" | ||
override val name: String = "Imputer" | ||
override val description: String = | ||
"Completes missing values using Estimator on a DataFrame" | ||
|
||
override lazy val tTagTI_0: TypeTag[DataFrame] = typeTag | ||
override lazy val tTagTO_0: TypeTag[DataFrame] = typeTag | ||
override lazy val tTagTO_1: TypeTag[InputerTransformer] = typeTag | ||
|
||
override val since: Version = Version(1, 5, 0) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/** | ||
* Copyright 2017 deepsense.ai (CodiLime, Inc) | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
name := "seahorse-executor-sparkutils2.2.x" | ||
|
||
libraryDependencies ++= Dependencies.sparkutils(Version.spark) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see Imputer and ImputerModel in Spark, which means Imputer is an Estimator which trains ImputerModel, which is in turn used to transform dataframes. We should have it reflected in seahorse. You can do it in a manner similar to how we handle it in other operations, using SparkEstimatorWrapper, SparkModelWrapper and than use EstimatorAsOperation on wrapped estimator.