feat: add run_async support for OllamaDocumentEmbedder #1878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:ollama
type:documentation
|
Thanks @Amnah199 this should be good to review. |
Amnah199
reviewed
Jun 6, 2025
integrations/ollama/src/haystack_integrations/components/embedders/ollama/document_embedder.py
Show resolved
Hide resolved
Amnah199
reviewed
Jun 6, 2025
integrations/ollama/src/haystack_integrations/components/embedders/ollama/document_embedder.py
Outdated
Show resolved
Hide resolved
Amnah199
reviewed
Jun 6, 2025
integrations/ollama/src/haystack_integrations/components/embedders/ollama/document_embedder.py
Show resolved
Hide resolved
srini047
force-pushed
the
run_async_ollama_document_embedder
branch
from
ef20670 to
be4ae4f
Compare
srini047
force-pushed
the
run_async_ollama_document_embedder
branch
2 times, most recently
from
e3720a7 to
a0524a1
Compare
srini047
force-pushed
the
run_async_ollama_document_embedder
branch
from
a0524a1 to
81eec3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
OllamaDocumentEmbedder#1509Proposed Changes:
Added
run_asyncconversion forOllamaDocumentEmbedderHow did you test it?
Added a seperate test case for testing async feature.
Notes for the reviewer
To be merged after #1877 since dependencies are present there.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.