Add http_client utils test

Author: Amnah199

test/components/embedders/test_azure_document_embedder.py

@@ -231,18 +231,6 @@ def test_init_http_client(self, monkeypatch):
         client = init_http_client(embedder.http_client_kwargs, async_client=True)
         assert isinstance(client, httpx.AsyncClient)
 
-    def test_http_client_kwargs_type_validation(self, monkeypatch):
-        monkeypatch.setenv("AZURE_OPENAI_API_KEY", "fake-api-key")
-        monkeypatch.setenv("AZURE_OPENAI_ENDPOINT", "https://test.openai.azure.com")
-        with pytest.raises(TypeError, match="The parameter 'http_client_kwargs' must be a dictionary."):
-            AzureOpenAIDocumentEmbedder(http_client_kwargs="invalid_argument")
-
-    def test_http_client_kwargs_with_invalid_params(self, monkeypatch):
-        monkeypatch.setenv("AZURE_OPENAI_API_KEY", "fake-api-key")
-        monkeypatch.setenv("AZURE_OPENAI_ENDPOINT", "https://test.openai.azure.com")
-        with pytest.raises(TypeError, match="unexpected keyword argument"):
-            AzureOpenAIDocumentEmbedder(http_client_kwargs={"invalid_key": "invalid_value"})
-
     @pytest.mark.integration
     @pytest.mark.skipif(
         not os.environ.get("AZURE_OPENAI_API_KEY", None) and not os.environ.get("AZURE_OPENAI_ENDPOINT", None),

test/components/embedders/test_azure_text_embedder.py

@@ -185,18 +185,6 @@ def test_init_http_client(self, monkeypatch):
         client = init_http_client(embedder.http_client_kwargs, async_client=True)
         assert isinstance(client, httpx.AsyncClient)
 
-    def test_http_client_kwargs_type_validation(self, monkeypatch):
-        monkeypatch.setenv("AZURE_OPENAI_API_KEY", "fake-api-key")
-        monkeypatch.setenv("AZURE_OPENAI_ENDPOINT", "https://test.openai.azure.com")
-        with pytest.raises(TypeError, match="The parameter 'http_client_kwargs' must be a dictionary."):
-            AzureOpenAITextEmbedder(http_client_kwargs="invalid_argument")
-
-    def test_http_client_kwargs_with_invalid_params(self, monkeypatch):
-        monkeypatch.setenv("AZURE_OPENAI_API_KEY", "fake-api-key")
-        monkeypatch.setenv("AZURE_OPENAI_ENDPOINT", "https://test.openai.azure.com")
-        with pytest.raises(TypeError, match="unexpected keyword argument"):
-            AzureOpenAITextEmbedder(http_client_kwargs={"invalid_key": "invalid_value"})
-
     @pytest.mark.integration
     @pytest.mark.skipif(
         not os.environ.get("AZURE_OPENAI_API_KEY", None) and not os.environ.get("AZURE_OPENAI_ENDPOINT", None),

test/components/generators/chat/test_openai.py

@@ -288,16 +288,6 @@ def test_from_dict_fail_wo_env_var(self, monkeypatch):
         with pytest.raises(ValueError):
             OpenAIChatGenerator.from_dict(data)
 
-    def test_http_client_kwargs_type_validation(self, monkeypatch):
-        monkeypatch.setenv("OPENAI_API_KEY", "test-api-key")
-        with pytest.raises(TypeError, match="The parameter 'http_client_kwargs' must be a dictionary."):
-            OpenAIChatGenerator(http_client_kwargs="invalid_argument")
-
-    def test_http_client_kwargs_with_invalid_params(self, monkeypatch):
-        monkeypatch.setenv("OPENAI_API_KEY", "test-api-key")
-        with pytest.raises(TypeError, match="unexpected keyword argument"):
-            OpenAIChatGenerator(http_client_kwargs={"invalid_key": "invalid_value"})
-
     def test_run(self, chat_messages, openai_mock_chat_completion):
         component = OpenAIChatGenerator(api_key=Secret.from_token("test-api-key"))
         response = component.run(chat_messages)

test/utils/test_http_client.py

@@ -0,0 +1,23 @@
+# SPDX-FileCopyrightText: 2022-present deepset GmbH <info@deepset.ai>
+#
+# SPDX-License-Identifier: Apache-2.0
+
+
+import pytest
+from haystack.utils.http_client import init_http_client
+
+
+def test_init_http_client():
+    http_client = init_http_client(http_client_kwargs={"base_url": "https://example.com"})
+    assert http_client is not None
+    assert http_client.base_url == "https://example.com"
+
+
+def test_http_client_kwargs_type_validation():
+    with pytest.raises(TypeError, match="The parameter 'http_client_kwargs' must be a dictionary."):
+        init_http_client(http_client_kwargs="invalid")
+
+
+def test_http_client_kwargs_with_invalid_params():
+    with pytest.raises(TypeError, match="unexpected keyword argument"):
+        init_http_client(http_client_kwargs={"invalid_key": "invalid"})