Skip to content

refactor: use token inSentenceTransformersDiversityRanker #9126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 28, 2025
Merged

refactor: use token inSentenceTransformersDiversityRanker #9126

merged 5 commits into from
Mar 28, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Mar 27, 2025 •
edited
Loading

Related Issues

  • From the warnings while running tests, I noticed that in this component we were still using the deprecated use_auth_token.

Proposed Changes:

  • use token in SentenceTransformersDiversityRanker

How did you test it?

CI

Notes for the reviewer

I initially tried to update also SASEvaluator, but I found that the current implementation (with deprecated use_auth_token) is the only one compatible with both sentence-transformers 3.x and 4.x, so I avoided the change for the moment.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@anakin87 anakin87 changed the title chore: use token in SASEvaluator and SentenceTransformersDiversityRanker refactor: use token in SASEvaluator and SentenceTransformersDiversityRanker Mar 27, 2025
@anakin87 anakin87 marked this pull request as ready for review March 27, 2025 17:38
@anakin87 anakin87 requested review from a team as code owners March 27, 2025 17:38
@anakin87 anakin87 requested review from dfokina and davidsbatista and removed request for a team March 27, 2025 17:38
@coveralls
Copy link
Collaborator

coveralls commented Mar 27, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14127016594

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.173%
Totals Coverage Status
Change from base Build 14126286424: 0.0%
Covered Lines: 10140
Relevant Lines: 11245
💛 - Coveralls

@anakin87 anakin87 marked this pull request as draft March 27, 2025 18:01
@github-actions github-actions bot added the type:documentation Improvements on the docs label Mar 28, 2025
@anakin87 anakin87 marked this pull request as ready for review March 28, 2025 10:12
@anakin87 anakin87 changed the title refactor: use token in SASEvaluator and SentenceTransformersDiversityRanker refactor: use token inSentenceTransformersDiversityRanker Mar 28, 2025
@davidsbatista
Copy link
Contributor

LGTM!

@anakin87 anakin87 merged commit 01957b1 into main Mar 28, 2025
17 checks passed
@anakin87 anakin87 deleted the replace-use-auth-token branch March 28, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @davidsbatista