Skip to content

ci: make lint workflow check pyproject.toml #9199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Apr 9, 2025

Related Issues

When changing dependencies, the lint workflow (including mypy) should run appropriately to find type issues.
This did not happen, for example, in #9178.

Proposed Changes:

  • make the lint workflow also monitor pyproject.toml

How did you test it?

I tested this in this PR, triggering lint with a change to pyproject.toml. Mypy ran: https://github.com/deepset-ai/haystack/actions/runs/14353439800/job/40237681508

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14353439800

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 90.371%

Totals Coverage Status
Change from base Build 14350711803: 0.03%
Covered Lines: 10652
Relevant Lines: 11787

💛 - Coveralls

@anakin87 anakin87 changed the title ci: make lint workflow run when pyproject is modified ci: make lint workflow check pyproject.toml Apr 9, 2025
@anakin87 anakin87 marked this pull request as ready for review April 9, 2025 09:32
@anakin87 anakin87 requested a review from a team as a code owner April 9, 2025 09:32
@anakin87 anakin87 requested review from Amnah199 and removed request for a team April 9, 2025 09:32
Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anakin87 anakin87 merged commit 7789876 into main Apr 9, 2025
9 checks passed
@anakin87 anakin87 deleted the lint-should-run-on-pyproject-changes branch April 9, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants