Skip to content

ci: fix lint job #9217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

ci: fix lint job #9217

merged 2 commits into from
Apr 11, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Apr 11, 2025

Related Issues

Proposed Changes:

  • change the lint job to trigger when pyproject.toml is changed but do not pass pyproject.toml to pylint

How did you test it?

CI; made a change in pyproject in f1313dc to trigger the job -> https://github.com/deepset-ai/haystack/actions/runs/14399118142/job/40381073183 no errors

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14399118142

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.388%

Totals Coverage Status
Change from base Build 14399005423: 0.0%
Covered Lines: 10683
Relevant Lines: 11819

💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review April 11, 2025 08:50
@anakin87 anakin87 requested a review from a team as a code owner April 11, 2025 08:50
@anakin87 anakin87 requested review from julian-risch and sjrl and removed request for a team and julian-risch April 11, 2025 08:50
Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anakin87 anakin87 merged commit 08fa1db into main Apr 11, 2025
9 checks passed
@anakin87 anakin87 deleted the fix-lint-job branch April 11, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants