Skip to content

chore: cleaning imports and unused variables in Component tests #9324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

chore: cleaning imports and unused variables in Component tests #9324

merged 1 commit into from
Apr 29, 2025

Conversation

davidsbatista
Copy link
Contributor

Proposed Changes:

  • removing unused imports in Component tests
  • noting unused variables

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 29, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14733422914

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.513%
Totals Coverage Status
Change from base Build 14733019619: 0.0%
Covered Lines: 10896
Relevant Lines: 12038
💛 - Coveralls

@davidsbatista davidsbatista changed the title chore: cleaning imports and unused variables in Component tests chore: cleaning imports and unused variables in Component tests Apr 29, 2025
@davidsbatista davidsbatista marked this pull request as ready for review April 29, 2025 14:21
@davidsbatista davidsbatista requested a review from a team as a code owner April 29, 2025 14:21
@davidsbatista davidsbatista requested review from julian-risch and removed request for a team April 29, 2025 14:21
julian-risch
julian-risch approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@davidsbatista davidsbatista merged commit 07f4bf5 into main Apr 29, 2025
23 of 24 checks passed
@davidsbatista davidsbatista deleted the cleaning-imports branch April 29, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidsbatista @coveralls @julian-risch